From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 11/18 V2]: PVH xen: some misc changes like
 mtrr, intr, msi.
Date: Mon, 18 Mar 2013 18:20:18 -0700
Message-ID: <20130318182018.2fd92acb@mantra.us.oracle.com>
References: <20130315174605.4090e816@mantra.us.oracle.com>
	<514714C702000078000C6590@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <514714C702000078000C6590@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 18 Mar 2013 12:21:11 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:

>  >>> On 16.03.13 at 01:46, Mukesh Rathor <mukesh.rathor@oracle.com>
>  >>> wrote:
> > +++ b/xen/arch/x86/msi.c
> > @@ -787,10 +787,15 @@ static int msix_capability_init(struct
> > pci_dev *dev, 
> >      if ( !dev->msix_used_entries )
> >      {
> > -        if ( rangeset_add_range(mmio_ro_ranges,
> > dev->msix_table.first,
> > +        /* PVH: this is temporary only until linux msi.c is fixed.
> > See xen-devel
> > +         * thread: "[PVH]: Help: msi.c".
> > +         */
> > +        if ( !is_pvh_domain(dev->domain) &&
> > +             rangeset_add_range(mmio_ro_ranges,
> > dev->msix_table.first, dev->msix_table.last) )
> >              WARN();
> > -        if ( rangeset_add_range(mmio_ro_ranges,
> > dev->msix_pba.first,
> > +        if ( !is_pvh_domain(dev->domain) &&
> > +             rangeset_add_range(mmio_ro_ranges,
> > dev->msix_pba.first, dev->msix_pba.last) )
> >              WARN();
> >  
> 
> As already said before, the whole change above has my explicit
> NAK.
> Jan

Do you have any suggestions? Do you want to hold off on entire xen patch
until we go fix linux for this? Or can we just omit this change in the next
V 3 and come back to this later.  Would you be OK with that?

thanks
MR