From: Tim Deegan <tim@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c
Date: Fri, 22 Mar 2013 10:06:43 +0000 [thread overview]
Message-ID: <20130322100643.GC25310@ocelot.phlegethon.org> (raw)
In-Reply-To: <514C251702000078000C7ADA@nat28.tlf.novell.com>
At 08:32 +0000 on 22 Mar (1363941127), Jan Beulich wrote:
> >>> On 21.03.13 at 17:49, Tim Deegan <tim@xen.org> wrote:
> >> + else if (cr == 3) {
> >> + printk("PVH: d%d: unexpected cr3 access vmexit. rip:%lx\n",
> >
> >> + current->domain->domain_id, regs->rip);
> >> + domain_crash_synchronous();
> >
> > Again, ITYM BUG(). And again. probably a switch statement.
>
> Actually, in cases where just crashing the guest is safe (i.e. no
> other execution state is corrupted), I think avoiding the use of
> BUG() is quite desirable. I wouldn't mind an ASSERT() though, to
> catch developers' attention.
Ack, ASSERT() + crash is better.
Tim.
next prev parent reply other threads:[~2013-03-22 10:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 0:41 [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c Mukesh Rathor
2013-03-18 12:16 ` Jan Beulich
2013-04-02 0:08 ` Mukesh Rathor
2013-04-02 7:00 ` Jan Beulich
2013-03-18 16:32 ` Konrad Rzeszutek Wilk
2013-04-02 1:26 ` Mukesh Rathor
2013-04-02 14:10 ` Konrad Rzeszutek Wilk
2013-04-03 1:29 ` Mukesh Rathor
2013-04-03 14:40 ` Konrad Rzeszutek Wilk
2013-04-03 1:45 ` Mukesh Rathor
2013-04-03 1:42 ` Mukesh Rathor
2013-04-04 1:01 ` Mukesh Rathor
2013-04-04 8:23 ` Jan Beulich
2013-03-21 16:49 ` Tim Deegan
2013-03-22 8:32 ` Jan Beulich
2013-03-22 10:06 ` Tim Deegan [this message]
2013-04-03 1:37 ` Mukesh Rathor
2013-04-03 8:06 ` Jan Beulich
2013-04-03 23:38 ` Mukesh Rathor
2013-04-04 9:12 ` Tim Deegan
2013-04-04 23:00 ` Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322100643.GC25310@ocelot.phlegethon.org \
--to=tim@xen.org \
--cc=JBeulich@suse.com \
--cc=Xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).