From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 17/18 V2]: PVH xen: PVH dom0 creation...
Date: Tue, 26 Mar 2013 17:34:57 -0700 [thread overview]
Message-ID: <20130326173457.43722909@mantra.us.oracle.com> (raw)
In-Reply-To: <51471E3302000078000C65FD@nat28.tlf.novell.com>
On Mon, 18 Mar 2013 13:01:23 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:
> >>> On 16.03.13 at 02:06, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > +static __init void copy_pvh(char *dest, char *src, int bytes)
> > +{
> > + /* raw_copy_to_guest() -> copy_to_user_hvm -> __hvm_copy needs
> > curr
> > + * to point to the hvm/pvh vcpu. Hence for PVH dom0 we can't
> > use that.
> > + * So we just use dbg_rw_mem().
> > + */
> > + int rem = dbg_rw_mem((dbgva_t)dest, (unsigned char *)src,
> > bytes, 0, 1, 0);
>
> Same comment as before: This is not acceptable for a submission
> of a patch intended to be committed (i.e. non-RFC). You should
> have worked out a suitable solution to this before posting.
Well, the prev patch was RFC and I dind't hear anything on this, so
(mis) understood this was acceptable. Ok, I will just implmement
copy_pvh() here.
next prev parent reply other threads:[~2013-03-27 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 1:06 [PATCH 17/18 V2]: PVH xen: PVH dom0 creation Mukesh Rathor
2013-03-18 13:01 ` Jan Beulich
2013-03-27 0:34 ` Mukesh Rathor [this message]
2013-03-29 0:32 ` Mukesh Rathor
2013-04-02 7:03 ` Jan Beulich
2013-03-18 20:06 ` Konrad Rzeszutek Wilk
2013-03-26 23:25 ` Mukesh Rathor
2013-03-19 9:27 ` Jan Beulich
2013-03-19 13:32 ` Konrad Rzeszutek Wilk
2013-03-26 23:42 ` Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326173457.43722909@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).