From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 5/6] xl: export 'outstanding_pages' value from xcinfo Date: Fri, 29 Mar 2013 16:07:20 -0400 Message-ID: <20130329200720.GA6467@phenom.dumpdata.com> References: <1364417739-10121-1-git-send-email-konrad.wilk@oracle.com> <1364417739-10121-6-git-send-email-konrad.wilk@oracle.com> <20820.29542.207528.170395@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20820.29542.207528.170395@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Dan Magenheimer , "xen-devel@lists.xensource.com" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Thu, Mar 28, 2013 at 04:44:22PM +0000, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH 5/6] xl: export 'outstanding_pages' value from xcinfo"): > > This patch provides the value of the currently outstanding pages > > claimed for a specific domain. This is a value that influences > > the global outstanding claims value (See patch: "xl: 'xl info' > > print outstanding claims if enabled") returned via > > xc_domain_get_outstanding_pages hypercall. This domain value > > decrements as the memory is populated for the guest and > > eventually reaches zero. > > Again this patch is fine as far as it goes but we need an update to > the documentation with a clear and accurate definition of what these > values are. The original patch (v11) had this outputed to SXP but as that is in the 'do-not-touch' that part had to be removed. And the 'libxl_dominfo' structure that comes out of this change, is only consumed in couple of places and only certain attributes: - domid in 'list_domains_details'. - domid, vcpu_online, blocked, paused, shutdown, dying, cpu_time, ssidref in 'list_domains'. - vcpu_online in 'main_cpupoolnumasplit'. - current_memkb, shared_memkb, domid, shutdown in 'sharing'. Nobody seems to be using 'page_memkb', nor 'vcpu_max_id'. I could provide the 'outstanding_memkb' value as part of 'list_domains' but that would alter the existing format it has. I could create an 'xl claim' that would be similar to 'xl list' but also include the claim information. But I am not sure whether there is a need for it. The 'outstanding_claims' via (xl info) is good enough for it. So your call - My thinking was that this could be in the code to be potentially used in the future (hand-waving how), but I am also OK with just dropping this patch and the earlier: xl/xc: export outstanding_pages value in xc_dominfo structure. Let me actually drop it from the next posting - it is always nicer to have a slimmed down version of patchsets.