Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Mon, 18 Mar 2013 12:16:50 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 16.03.13 at 01:41, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > +static int pvh_grant_table_op(
> > +              unsigned int cmd, XEN_GUEST_HANDLE(void) uop,
> > unsigned int count) +{
> > +    switch (cmd)
> > +    {
> > +        case GNTTABOP_map_grant_ref:
> > +        case GNTTABOP_unmap_grant_ref:
> > +        case GNTTABOP_setup_table:
> > +        case GNTTABOP_copy:
> > +        case GNTTABOP_query_size:
> > +        case GNTTABOP_set_version:
> > +            return do_grant_table_op(cmd, uop, count);
> 
> While for HVM guests such white lists may be appropriate, for PVH
> this doesn't seem to be the case: The code would require updating
> whenever a new sub-hypercall gets added to any of the hypercalls
> dealt with like this.

Right, these are verified for PVH. As they are added, they would need
to be verfied to make sure OK for PVH. We can remove this later. I can
ifdef DEBUG if you'd like.