From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c Date: Mon, 1 Apr 2013 17:08:24 -0700 Message-ID: <20130401170824.4dd25565@mantra.us.oracle.com> References: <20130315174145.4bc0e78f@mantra.us.oracle.com> <514713C202000078000C657D@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <514713C202000078000C657D@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 18 Mar 2013 12:16:50 +0000 "Jan Beulich" wrote: > >>> On 16.03.13 at 01:41, Mukesh Rathor > >>> wrote: > > +static int pvh_grant_table_op( > > + unsigned int cmd, XEN_GUEST_HANDLE(void) uop, > > unsigned int count) +{ > > + switch (cmd) > > + { > > + case GNTTABOP_map_grant_ref: > > + case GNTTABOP_unmap_grant_ref: > > + case GNTTABOP_setup_table: > > + case GNTTABOP_copy: > > + case GNTTABOP_query_size: > > + case GNTTABOP_set_version: > > + return do_grant_table_op(cmd, uop, count); > > While for HVM guests such white lists may be appropriate, for PVH > this doesn't seem to be the case: The code would require updating > whenever a new sub-hypercall gets added to any of the hypercalls > dealt with like this. Right, these are verified for PVH. As they are added, they would need to be verfied to make sure OK for PVH. We can remove this later. I can ifdef DEBUG if you'd like.