Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Tue, 2 Apr 2013 10:10:12 -0400
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:

> On Mon, Apr 01, 2013 at 06:26:45PM -0700, Mukesh Rathor wrote:
> > On Mon, 18 Mar 2013 12:32:06 -0400
> > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > 
> > > 
> > > > +}
> > > > +
> > > > +typedef unsigned long pvh_hypercall_t(
> > > > +    unsigned long, unsigned long, unsigned long, unsigned long,
> > > > unsigned long,
> > > > +    unsigned long);
> > > 
> > > No way to re-use the something standard? I am not sure what is
> > > 'PVH' specific to it? It looks like a garden variety normal
> > > hypercalls.
> > 
> > It does use standard do_xx calls, PV goes thru it's own table, HVM
> > thru its own, and PVH thru its own. This was suggested to me early
> > on, and it's easier this way since HVM and PVH are not same hcalls.
> 
> I meant the typedef.

Ok, I could move the hvm_typedef* to header, and use that. no biggie.