From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and
 pvh.c
Date: Tue, 2 Apr 2013 18:45:29 -0700
Message-ID: <20130402184529.4e0e9f63@mantra.us.oracle.com>
References: <20130315174145.4bc0e78f@mantra.us.oracle.com>
	<20130318163206.GM24560@phenom.dumpdata.com>
	<20130401182645.4925afa4@mantra.us.oracle.com>
	<20130402141012.GB1754@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130402141012.GB1754@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2 Apr 2013 10:10:12 -0400
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:

> On Mon, Apr 01, 2013 at 06:26:45PM -0700, Mukesh Rathor wrote:
> > On Mon, 18 Mar 2013 12:32:06 -0400
> > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > 
> > > 
> > > > +}
> > > > +
> > > > +typedef unsigned long pvh_hypercall_t(
> > > > +    unsigned long, unsigned long, unsigned long, unsigned long,
> > > > unsigned long,
> > > > +    unsigned long);
> > > 
> > > No way to re-use the something standard? I am not sure what is
> > > 'PVH' specific to it? It looks like a garden variety normal
> > > hypercalls.
> > 
> > It does use standard do_xx calls, PV goes thru it's own table, HVM
> > thru its own, and PVH thru its own. This was suggested to me early
> > on, and it's easier this way since HVM and PVH are not same hcalls.
> 
> I meant the typedef.

Ok, I could move the hvm_typedef* to header, and use that. no biggie.