From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Tim Deegan <tim@xen.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>
Subject: Re: [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c
Date: Thu, 4 Apr 2013 16:00:16 -0700 [thread overview]
Message-ID: <20130404160016.16b38274@mantra.us.oracle.com> (raw)
In-Reply-To: <20130404091219.GA42936@ocelot.phlegethon.org>
On Thu, 4 Apr 2013 10:12:19 +0100
Tim Deegan <tim@xen.org> wrote:
> At 18:37 -0700 on 02 Apr (1364927854), Mukesh Rathor wrote:
> > On Thu, 21 Mar 2013 16:49:12 +0000 Tim Deegan <tim@xen.org> wrote:
> > > > +static int vmxit_invlpg(void)
> > > > +{
> > > > + ulong vaddr = __vmread(EXIT_QUALIFICATION);
> > > > +
> > > > + vmx_update_guest_eip();
> > > > + vpid_sync_vcpu_gva(current, vaddr);
> > >
> > > If there's no special handling of invlpg, you should just not
> > > intercept it.
> >
> > well, we call vpid_sync_vcpu_gva(), but we can optimize this further
> > in future.
>
> It would be trivial just to drop the intercept now. All
> vpid_sync_vcpu_gva() does is emulate (potentially rather
> inefficiently) the invlpg that's been intercepted.
Ok, got it now. Thanks.
prev parent reply other threads:[~2013-04-04 23:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 0:41 [PATCH 10/18 V2]: PVH xen: introduce vmx_pvh.c and pvh.c Mukesh Rathor
2013-03-18 12:16 ` Jan Beulich
2013-04-02 0:08 ` Mukesh Rathor
2013-04-02 7:00 ` Jan Beulich
2013-03-18 16:32 ` Konrad Rzeszutek Wilk
2013-04-02 1:26 ` Mukesh Rathor
2013-04-02 14:10 ` Konrad Rzeszutek Wilk
2013-04-03 1:29 ` Mukesh Rathor
2013-04-03 14:40 ` Konrad Rzeszutek Wilk
2013-04-03 1:45 ` Mukesh Rathor
2013-04-03 1:42 ` Mukesh Rathor
2013-04-04 1:01 ` Mukesh Rathor
2013-04-04 8:23 ` Jan Beulich
2013-03-21 16:49 ` Tim Deegan
2013-03-22 8:32 ` Jan Beulich
2013-03-22 10:06 ` Tim Deegan
2013-04-03 1:37 ` Mukesh Rathor
2013-04-03 8:06 ` Jan Beulich
2013-04-03 23:38 ` Mukesh Rathor
2013-04-04 9:12 ` Tim Deegan
2013-04-04 23:00 ` Mukesh Rathor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404160016.16b38274@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Xen-devel@lists.xensource.com \
--cc=tim@xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).