Re: [PATCH 12/18 V2]:PVH xen: support invalid op, return PVH features etc...

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Mon, 18 Mar 2013 13:48:43 -0400
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:

> On Fri, Mar 15, 2013 at 05:48:44PM -0700, Mukesh Rathor wrote:
> >  The biggest change in this patch is in traps.c to allow forced
> > invalid op for PVH guest. Also, enable hypercall page init for PVH
> > guest also. Finally, set guest type to PVH if PV with HAP is
> > created.
> > 
> > index ab54f82..14656c1 100644
> > --- a/xen/arch/x86/traps.c
> > +++ b/xen/arch/x86/traps.c
> > @@ -459,6 +459,10 @@ static void instruction_done(
> >      struct cpu_user_regs *regs, unsigned long eip, unsigned int
> > bpmatch) {
> >      regs->eip = eip;
> > +
> > +    if ( is_pvh_vcpu(current) )
> > +        return;
> 
> Can it be above the 'regs->eip = eip' ?

No it can't.

> > @@ -149,6 +149,8 @@ void getdomaininfo(struct domain *d, struct
> > xen_domctl_getdomaininfo *info) 
> >      if ( is_hvm_domain(d) )
> >          info->flags |= XEN_DOMINF_hvm_guest;
> > +    else if ( is_pvh_domain(d) )
> > +        info->flags |= XEN_DOMINF_pvh_guest;
> >  
> >      xsm_security_domaininfo(d, info);
> >  
> > @@ -400,6 +402,8 @@ long
> > do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
> > domcr_flags = 0; if ( op->u.createdomain.flags &
> > XEN_DOMCTL_CDF_hvm_guest ) domcr_flags |= DOMCRF_hvm;
> > +        else if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_hap )
> > +            domcr_flags |= DOMCRF_pvh;     /* PV with HAP is a PVH
> > guest */
> 
> <scratches his head>
> 
> So if the user sets: 'hap' in their guest config we automatically
> set domcr_flags to DOMCRF_hvm | DOMCRF_pvh right?
> 

No. hap doesn't automatically result in setting of DOMCRF_hvm.