From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [PATCH 12/18 V2]:PVH xen: support invalid op, return PVH features etc... Date: Fri, 5 Apr 2013 15:21:07 -0700 Message-ID: <20130405152107.653522e4@mantra.us.oracle.com> References: <20130315174844.7fc9bc2c@mantra.us.oracle.com> <5147165302000078000C65A8@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5147165302000078000C65A8@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 18 Mar 2013 12:27:47 +0000 "Jan Beulich" wrote: > >>> On 16.03.13 at 01:48, Mukesh Rathor > >>> wrote: > > --- a/xen/arch/x86/traps.c > > +++ b/xen/arch/x86/traps.c > > @@ -459,6 +459,10 @@ static void instruction_done( > > struct cpu_user_regs *regs, unsigned long eip, unsigned int > > bpmatch) { > > regs->eip = eip; > > + > > + if ( is_pvh_vcpu(current) ) > > + return; > > So how would breakpoint matching on emulated instructions work? Should be same as HVM guest, but I'll add action item to investigate more. thanks, Mukesh