From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 12/17] PVH xen: support invalid op,
 return PVH features etc...
Date: Wed, 24 Apr 2013 18:01:13 -0700
Message-ID: <20130424180113.0b8db2ad@mantra.us.oracle.com>
References: <1366752366-16594-1-git-send-email-mukesh.rathor@oracle.com>
	<1366752366-16594-13-git-send-email-mukesh.rathor@oracle.com>
	<5177BB8602000078000D03F1@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5177BB8602000078000D03F1@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 24 Apr 2013 10:01:26 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 23.04.13 at 23:26, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > --- a/xen/arch/x86/debug.c
> > +++ b/xen/arch/x86/debug.c
> > @@ -59,7 +59,9 @@ dbg_hvm_va2mfn(dbgva_t vaddr, struct domain *dp,
> > int toaddr, return INVALID_MFN;
> >      }
> >  
> > -    mfn = mfn_x(get_gfn(dp, *gfn, &gfntype)); 
> > +    mfn = mfn_x(get_gfn_query(dp, *gfn, &gfntype));
> > +    put_gfn(dp, *gfn);
> > +
> >      if ( p2m_is_readonly(gfntype) && toaddr )
> >      {
> >          DBGP2("kdb:p2m_is_readonly: gfntype:%x\n", gfntype);
> > @@ -178,9 +180,6 @@ dbg_rw_guest_mem(dbgva_t addr, dbgbyte_t *buf,
> > int len, struct domain *dp, }
> >  
> >          unmap_domain_page(va);
> > -        if ( gfn != INVALID_GFN )
> > -            put_gfn(dp, gfn);
> > -
> >          addr += pagecnt;
> >          buf += pagecnt;
> >          len -= pagecnt;
> 
> How is this change related to PVH? I.e. isn't this a standalone fix/
> change?
> 
> Jan

fine. I'll move it to a separate patch.

thanks,
Mukesh