From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 13/17] PVH xen: p2m related changes.
Date: Thu, 25 Apr 2013 12:28:13 +0100
Message-ID: <20130425112813.GC37678@ocelot.phlegethon.org>
References: <1366752366-16594-1-git-send-email-mukesh.rathor@oracle.com>
	<1366752366-16594-14-git-send-email-mukesh.rathor@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1366752366-16594-14-git-send-email-mukesh.rathor@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

At 14:26 -0700 on 23 Apr (1366727162), Mukesh Rathor wrote:
> In this patch, I introduce  a new type p2m_map_foreign for pages that a
> dom0 maps from foreign domains its creating. Also, add
> set_foreign_p2m_entry() to map p2m_map_foreign type pages. Other misc changes
> related to p2m.

You haven't addressed my comments from v2:
http://lists.xen.org/archives/html/xen-devel/2013-03/msg01895.html

In particular this:

>      /* Track the highest gfn for which we have ever had a valid mapping */
> -    if ( p2mt != p2m_invalid &&
> +    if ( p2mt != p2m_invalid && p2mt != p2m_mmio_dm &&
>           (gfn + (1UL << order) - 1 > p2m->max_mapped_pfn) )
>          p2m->max_mapped_pfn = gfn + (1UL << order) - 1;

seems like a big change to be hiding away in a 'p2m related changes'
patch without a good explanation of what you're doing and why.

Tim.