From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH 14/17] PVH xen: Add and remove foreign pages
Date: Thu, 25 Apr 2013 12:38:22 +0100
Message-ID: <20130425113822.GD37678@ocelot.phlegethon.org>
References: <1366752366-16594-1-git-send-email-mukesh.rathor@oracle.com>
	<1366752366-16594-15-git-send-email-mukesh.rathor@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1366752366-16594-15-git-send-email-mukesh.rathor@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

At 14:26 -0700 on 23 Apr (1366727163), Mukesh Rathor wrote:
> In this patch, a new function, xenmem_add_foreign_to_pmap(), is added
> to map pages from foreign guest into current dom0 for domU creation.
> Also, allow XENMEM_remove_from_physmap to remove p2m_map_foreign
> pages. Note, in this path, we must release the refcount that was taken
> during the map phase.

Much better, thanks!

One comment: 

> +    if ( currd->domain_id == foreign_domid || foreign_domid == DOMID_SELF ||
> +         !is_pvh_domain(currd) )
> +        return -EINVAL;

If you're not going to implement XENMAPSPACE_gmfn_foreign for normal HVM
domains, can you please add a comment to public/memory.h to say that
it's PVH-only on x86. 

Thanks,

Tim.