From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 13/17] PVH xen: p2m related changes.
Date: Thu, 25 Apr 2013 14:59:33 -0700
Message-ID: <20130425145933.182d59c4@mantra.us.oracle.com>
References: <1366752366-16594-1-git-send-email-mukesh.rathor@oracle.com>
	<1366752366-16594-14-git-send-email-mukesh.rathor@oracle.com>
	<20130425112813.GC37678@ocelot.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130425112813.GC37678@ocelot.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: Xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 25 Apr 2013 12:28:13 +0100
Tim Deegan <tim@xen.org> wrote:

> At 14:26 -0700 on 23 Apr (1366727162), Mukesh Rathor wrote:
> > In this patch, I introduce  a new type p2m_map_foreign for pages
> > that a dom0 maps from foreign domains its creating. Also, add
> > set_foreign_p2m_entry() to map p2m_map_foreign type pages. Other
> > misc changes related to p2m.
> 
> You haven't addressed my comments from v2:
> http://lists.xen.org/archives/html/xen-devel/2013-03/msg01895.html
> 
> In particular this:
> 
> >      /* Track the highest gfn for which we have ever had a valid
> > mapping */
> > -    if ( p2mt != p2m_invalid &&
> > +    if ( p2mt != p2m_invalid && p2mt != p2m_mmio_dm &&
> >           (gfn + (1UL << order) - 1 > p2m->max_mapped_pfn) )
> >          p2m->max_mapped_pfn = gfn + (1UL << order) - 1;
> 
> seems like a big change to be hiding away in a 'p2m related changes'
> patch without a good explanation of what you're doing and why.
> 
> Tim.

Remember:
http://lists.xen.org/archives/html/xen-devel/2012-03/msg02456.html

Ok, I'll comment saying "because Tim says so", just kidding..... 

Ok how about comment like this:

/*
 * PVH maps the entire mmio 1-1. Hence we must adjust the max_mapped_pfn
 * to account for that. Such mfns are p2m_mmio_direct and !mfn_valid.
 */

I can't think of better way of saying it, so please feel free to send 
better version if you can.

thanks,
Mukesh