From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 16/17] PVH xen: elf and iommu related
 changes to prep for dom0 PVH
Date: Mon, 13 May 2013 18:16:40 -0700
Message-ID: <20130513181640.08b012a7@mantra.us.oracle.com>
References: <1366752366-16594-1-git-send-email-mukesh.rathor@oracle.com>
	<1366752366-16594-17-git-send-email-mukesh.rathor@oracle.com>
	<5177BECD02000078000D0413@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5177BECD02000078000D0413@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 24 Apr 2013 10:15:25 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 23.04.13 at 23:26, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> >  
> > -static int elf_load_image(void *dst, const void *src, uint64_t
> > filesz, uint64_t memsz) +extern void __init
> > early_pvh_copy_or_zero(unsigned long dest, char *src,
> > +                                          int len, unsigned long
> > v_start);
> 
> This needs to be put in a header included both here and at the
> producer side.
> 
> Also, if you need to pass v_start around just to pass it back to
> this function, you could as well store it in a static variable in
> domain_build.c, and leave all of these functions untouched.

Actually, elf_load_image() <-- elf_load_binary() needs to know if it's 
PVH domain, so I'd need to change it to pass is_pvh_domain anyways. 

I could check for idle_domain in elf_load_binary() and assume PVH dom0
construct, since for other callers, current should never be idle domain,
but, that seems pretty hacky... 

So, I could either leave it as is with v_start being passed, or make
v_start static and pass is_pvh_domain flag. Please LMK.

thanks,
mukesh