From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 19/20] PVH xen: elf and iommu related
 changes to prep for dom0 PVH
Date: Thu, 16 May 2013 18:14:24 -0700
Message-ID: <20130516181424.31e0f024@mantra.us.oracle.com>
References: <1368579168-30829-1-git-send-email-mukesh.rathor@oracle.com>
	<1368579168-30829-20-git-send-email-mukesh.rathor@oracle.com>
	<519397E802000078000D6718@nat28.tlf.novell.com>
	<20130515185817.27b83538@mantra.us.oracle.com>
	<5194AEE402000078000D6A33@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5194AEE402000078000D6A33@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 16 May 2013 09:03:16 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 16.05.13 at 03:58, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > On Wed, 15 May 2013 13:12:56 +0100
> > "Jan Beulich" <JBeulich@suse.com> wrote:
> > 
> >> >>> On 15.05.13 at 02:52, Mukesh Rathor <mukesh.rathor@oracle.com>
> >> >>> wrote:
> >> > --- a/xen/arch/x86/setup.c
> >> > +++ b/xen/arch/x86/setup.c
> >> > @@ -60,6 +60,10 @@ integer_param("maxcpus", max_cpus);
> >> >  static bool_t __initdata disable_smep;
> >> >  invbool_param("smep", disable_smep);
> >> >  
> >> > +/* Boot dom0 in PVH mode */
> >> > +bool_t __initdata opt_dom0pvh;
> >> > +boolean_param("dom0pvh", opt_dom0pvh);
> >> 
> >> Does this really belong here (instead of domain_build.c)?
> > 
> > Yes, so we can pass the flag to domain_create() which sets the
> > guest type:
> > 
> >     domcr_flags = (opt_dom0pvh ? DOMCRF_pvh | DOMCRF_hap : 0);
> >     domcr_flags |= DOMCRF_s3_integrity;
> >     dom0 = domain_create(0, domcr_flags, 0);
> 
> The symbol is global, so use sites don't matter. And I continue to
> think that logically it belongs into domain_build.c.

Oh, you mean just the declarations, sure I can do that.

thanks
Mukesh