From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH RFC 5/6] arm64/xen: implement xen_remap on arm64 Date: Fri, 31 May 2013 15:16:01 +0100 Message-ID: <20130531141601.GC15551@arm.com> References: <1369930713-6063-5-git-send-email-stefano.stabellini@eu.citrix.com> <20130531105915.GC18045@localhost.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Stefano Stabellini Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" , Will Deacon , "Ian.Campbell@citrix.com" , "konrad.wilk@oracle.com" List-Id: xen-devel@lists.xenproject.org On Fri, May 31, 2013 at 02:21:16PM +0100, Stefano Stabellini wrote: > On Fri, 31 May 2013, Catalin Marinas wrote: > > On Thu, May 30, 2013 at 05:18:32PM +0100, Stefano Stabellini wrote: > > > --- a/arch/arm/include/asm/xen/page.h > > > +++ b/arch/arm/include/asm/xen/page.h > > > @@ -90,6 +90,10 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn) > > > return __set_phys_to_machine(pfn, mfn); > > > } > > > > > > +#ifdef CONFIG_ARM64 > > > +#define xen_remap(cookie, size) __ioremap((cookie), (size), __pgprot(PROT_NORMAL)) > > > +#else > > > #define xen_remap(cookie, size) __arm_ioremap((cookie), (size), MT_MEMORY); > > > +#endif > > > > Now I saw the ARM-specific part. Can you not use something like > > ioremap_cached() which would give normal cacheable memory (at least on > > ARMv7). > > No, I cannot because ioremap_cached uses MT_DEVICE_CACHED, while this > needs to be MT_MEMORY. It is used for normal memory pages, not device > memory. MT_DEVICE_CACHED is Normal memory for ARMv7. -- Catalin