From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [PATCH 04/18] PVH xen: add params to
 read_segment_register
Date: Fri, 7 Jun 2013 17:45:37 -0700
Message-ID: <20130607174537.0c3ce217@mantra.us.oracle.com>
References: <1369445137-19755-1-git-send-email-mukesh.rathor@oracle.com>
	<1369445137-19755-5-git-send-email-mukesh.rathor@oracle.com>
	<51A890CC02000078000D9F56@nat28.tlf.novell.com>
	<20130605182546.7c1ca5c5@mantra.us.oracle.com>
	<51B04CF102000078000DBC3D@nat28.tlf.novell.com>
	<20130606184328.0d56b3ae@mantra.us.oracle.com>
	<51B199F402000078000DC1CF@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51B199F402000078000DC1CF@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 07 Jun 2013 07:29:40 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 07.06.13 at 03:43, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > On Thu, 06 Jun 2013 07:48:49 +0100
> > "Jan Beulich" <JBeulich@suse.com> wrote:
> > 
> >> >>> On 06.06.13 at 03:25, Mukesh Rathor <mukesh.rathor@oracle.com>
> >> >>> wrote:
> >> > On Fri, 31 May 2013 11:00:12 +0100
> >> > "Jan Beulich" <JBeulich@suse.com> wrote:
> >> > 
........ 
> And anything we leave there should be optimized to hide latencies
> between dependent instructions (the worst example here likely is
> the CR2 read followed immediately by the intermediate register
> getting written to memory, even though the control register read
> could be done almost first thing in the handler).
> 
> One question though is why HVM code gets away without always
> filling those fields, but PVH code doesn't. Could you say a word
> on this?

Yeah, sure. The HVM IO instr emulation goes thru handle_mmio/handle_pio,
and I've not looked at them since the PVH goes thru emulate_privileged_op(),
which calls read_segment_register macro. The HVM functions do not call
the read_segment_register macro. 

Hope that helps.

Mukesh