* [patch] xen-netback: double free on unload
@ 2013-06-21 6:20 Dan Carpenter
2013-06-21 9:51 ` Wei Liu
2013-06-24 7:26 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-06-21 6:20 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, netdev, kernel-janitors
There is a typo here, "i" vs "j", so we would crash on module_exit().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index a0b50ad..130bcb2 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1968,8 +1968,8 @@ static void __exit netback_fini(void)
del_timer_sync(&netbk->net_timer);
kthread_stop(netbk->task);
for (j = 0; j < MAX_PENDING_REQS; j++) {
- if (netbk->mmap_pages[i])
- __free_page(netbk->mmap_pages[i]);
+ if (netbk->mmap_pages[j])
+ __free_page(netbk->mmap_pages[j]);
}
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] xen-netback: double free on unload
2013-06-21 6:20 [patch] xen-netback: double free on unload Dan Carpenter
@ 2013-06-21 9:51 ` Wei Liu
2013-06-24 7:26 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Wei Liu @ 2013-06-21 9:51 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Ian Campbell, xen-devel, netdev, kernel-janitors, wei.liu2
On Fri, Jun 21, 2013 at 09:20:08AM +0300, Dan Carpenter wrote:
> There is a typo here, "i" vs "j", so we would crash on module_exit().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index a0b50ad..130bcb2 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1968,8 +1968,8 @@ static void __exit netback_fini(void)
> del_timer_sync(&netbk->net_timer);
> kthread_stop(netbk->task);
> for (j = 0; j < MAX_PENDING_REQS; j++) {
> - if (netbk->mmap_pages[i])
> - __free_page(netbk->mmap_pages[i]);
> + if (netbk->mmap_pages[j])
> + __free_page(netbk->mmap_pages[j]);
Nice catch, thanks.
Wei.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] xen-netback: double free on unload
2013-06-21 6:20 [patch] xen-netback: double free on unload Dan Carpenter
2013-06-21 9:51 ` Wei Liu
@ 2013-06-24 7:26 ` David Miller
2013-06-24 7:31 ` Julia Lawall
2013-06-24 8:57 ` Dan Carpenter
1 sibling, 2 replies; 6+ messages in thread
From: David Miller @ 2013-06-24 7:26 UTC (permalink / raw)
To: dan.carpenter; +Cc: ian.campbell, xen-devel, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 21 Jun 2013 09:20:08 +0300
> There is a typo here, "i" vs "j", so we would crash on module_exit().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Please always explicitly state the tree for which a patch is
applicable.
Here I figured it out by trial an error, trying to apply it
to 'net' (where it failed) and then 'net-next' (where it
applied cleanly).
I should never have to play patch monkey games like that, you
need to tell me where a patch is targetted.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] xen-netback: double free on unload
2013-06-24 7:26 ` David Miller
@ 2013-06-24 7:31 ` Julia Lawall
2013-06-24 8:44 ` David Miller
2013-06-24 8:57 ` Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2013-06-24 7:31 UTC (permalink / raw)
To: David Miller
Cc: dan.carpenter, ian.campbell, xen-devel, netdev, kernel-janitors
On Mon, 24 Jun 2013, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Fri, 21 Jun 2013 09:20:08 +0300
>
> > There is a typo here, "i" vs "j", so we would crash on module_exit().
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Please always explicitly state the tree for which a patch is
> applicable.
>
> Here I figured it out by trial an error, trying to apply it
> to 'net' (where it failed) and then 'net-next' (where it
> applied cleanly).
>
> I should never have to play patch monkey games like that, you
> need to tell me where a patch is targetted.
Shouldn't one always, by default, work on linux-next?
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] xen-netback: double free on unload
2013-06-24 7:31 ` Julia Lawall
@ 2013-06-24 8:44 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2013-06-24 8:44 UTC (permalink / raw)
To: julia.lawall
Cc: dan.carpenter, ian.campbell, xen-devel, netdev, kernel-janitors
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Mon, 24 Jun 2013 08:31:31 +0100 (BST)
> On Mon, 24 Jun 2013, David Miller wrote:
>
>> From: Dan Carpenter <dan.carpenter@oracle.com>
>> Date: Fri, 21 Jun 2013 09:20:08 +0300
>>
>> > There is a typo here, "i" vs "j", so we would crash on module_exit().
>> >
>> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> Please always explicitly state the tree for which a patch is
>> applicable.
>>
>> Here I figured it out by trial an error, trying to apply it
>> to 'net' (where it failed) and then 'net-next' (where it
>> applied cleanly).
>>
>> I should never have to play patch monkey games like that, you
>> need to tell me where a patch is targetted.
>
> Shouldn't one always, by default, work on linux-next?
Bug fixes, especially serious ones, should be targetted at 'net'.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] xen-netback: double free on unload
2013-06-24 7:26 ` David Miller
2013-06-24 7:31 ` Julia Lawall
@ 2013-06-24 8:57 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2013-06-24 8:57 UTC (permalink / raw)
To: David Miller; +Cc: ian.campbell, xen-devel, netdev, kernel-janitors
I'm sorry. For some reason I got confused and thought this bug was
older. I'll update my QC scripts to test for this.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-24 8:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-21 6:20 [patch] xen-netback: double free on unload Dan Carpenter
2013-06-21 9:51 ` Wei Liu
2013-06-24 7:26 ` David Miller
2013-06-24 7:31 ` Julia Lawall
2013-06-24 8:44 ` David Miller
2013-06-24 8:57 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).