xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] don't compile XEN_TMEM on ARM adn ARM64
Date: Mon, 24 Jun 2013 12:00:41 -0400	[thread overview]
Message-ID: <20130624160041.GA23778@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1306241646400.4782@kaball.uk.xensource.com>

On Mon, Jun 24, 2013 at 04:51:17PM +0100, Stefano Stabellini wrote:
> Hi Konrad,
> XEN_TMEM doesn't work on ARM64. This commit break Xen ARM64 in
> linux-next:
> 
> commit 10a7a0771399a57a297fca9615450dbb3f88081a
> Author: Dan Magenheimer <dan.magenheimer@oracle.com>
> Date:   Tue Apr 30 15:27:00 2013 -0700
> 
>     xen: tmem: enable Xen tmem shim to be built/loaded as a module
> 
> I suggest fixing it by disabling XEN_TMEM on everything non-x86.

Hm, what is the compile issue?

> 
> ---
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 9e02d60..c1ac85b 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -145,7 +145,7 @@ config SWIOTLB_XEN
>  
>  config XEN_TMEM
>  	tristate
> -	depends on !ARM
> +	depends on X86
>  	default m if (CLEANCACHE || FRONTSWAP)
>  	help
>  	  Shim to interface in-kernel Transcendent Memory hooks

  parent reply	other threads:[~2013-06-24 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-24 15:51 [PATCH] don't compile XEN_TMEM on ARM adn ARM64 Stefano Stabellini
2013-06-24 15:58 ` Jan Beulich
2013-06-24 16:00 ` Konrad Rzeszutek Wilk [this message]
2013-06-24 16:12   ` Stefano Stabellini
2013-06-24 16:15     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130624160041.GA23778@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).