Re: [PATCH 15/18] PVH xen: add hypercall support for PVH

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Tue, 25 Jun 2013 11:12:25 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> > @@ -3777,7 +3815,7 @@ long do_hvm_op(unsigned long op,
> > XEN_GUEST_HANDLE_PARAM(void) arg) return -ESRCH;
> >  
> >          rc = -EINVAL;
> > -        if ( !is_hvm_domain(d) )
> > +        if ( is_pv_domain(d) )
> >              goto param_fail;
> >  
> >          rc = xsm_hvm_param(XSM_TARGET, d, op);
> > @@ -3949,7 +3987,7 @@ long do_hvm_op(unsigned long op,
> > XEN_GUEST_HANDLE_PARAM(void) arg) break;
> >              }
> >  
> > -            if ( rc == 0 ) 
> > +            if ( rc == 0 && !is_pvh_domain(d) )
> >              {
> >                  d->arch.hvm_domain.params[a.index] = a.value;
> >  
> 
> This last check I think you do because params[] points nowhere for
Correct.

> PVH guests. If so - why don't you just drop this and the earlier
> hunk? Or otherwise some of the case statements between need to

I don't understand, drop from where? You mean a totally separate function
for PVH (I had that in very earlier patches).

> also guard against accessing the unset pointer.

Correct, I'd need to do that. Originally, I had a white list of case
operations prohibited for PVH, but removed it.

-Mukesh