From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v6 2/5] kernel: missing include in cputime.c Date: Thu, 27 Jun 2013 16:17:19 +0200 Message-ID: <20130627141718.GA10056@gmail.com> References: <1372341272-12512-2-git-send-email-stefano.stabellini@eu.citrix.com> <20130627141209.GB29209@dyad.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130627141209.GB29209@dyad.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Peter Zijlstra Cc: Stefano Stabellini , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, konrad.wilk@oracle.com, catalin.marinas@arm.com, arnd@arndb.de, olof@lixom.net, linux@arm.linux.org.uk, Ian.Campbell@citrix.com, will.deacon@arm.com, marc.zyngier@arm.com, mingo@redhat.com List-Id: xen-devel@lists.xenproject.org * Peter Zijlstra wrote: > On Thu, Jun 27, 2013 at 02:54:29PM +0100, Stefano Stabellini wrote: > > steal_account_process_tick calls paravirt_steal_clock, but paravirt.h is > > currently missing amoung the included header files. > > Add include asm/paravirt.h ifdef CONFIG_PARAVIRT. > > > > Signed-off-by: Stefano Stabellini > > CC: mingo@redhat.com > > CC: peterz@infradead.org > > > > Changes in v5: > > - add ifdef CONFIG_PARAVIRT. > > --- > > kernel/sched/cputime.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c > > index cc2dc3ee..317a578 100644 > > --- a/kernel/sched/cputime.c > > +++ b/kernel/sched/cputime.c > > @@ -5,7 +5,9 @@ > > #include > > #include > > #include "sched.h" > > - > > +#ifdef CONFIG_PARAVIRT > > +#include > > +#endif > > Why isn't that CONFIG stuff inside the header instead of around it? Indeed. Once that is fixed then the #ifdef around asm/paravirt.h in kernel/sched/core.c could be removed as well. Thanks, Ingo