From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "G.R." <firemeteor@users.sourceforge.net>
Cc: Ian Campbell <ian.campbell@citrix.com>,
Ross Philipson <ross.philipson@citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xen.org>,
Jean Guyader <Jean.guyader@gmail.com>
Subject: Re: [PATCH 3/3] qemu-xen-trad: IGD passthrough: Expose vendor specific pci cap on host bridge.
Date: Mon, 1 Jul 2013 09:06:37 -0400 [thread overview]
Message-ID: <20130701130637.GA10934@phenom.dumpdata.com> (raw)
In-Reply-To: <CAKhsbWa8AES+M10uYkpAA1yhOQR_-7WeZ0ZR9Z-9HqB7=t3LCg@mail.gmail.com>
> >> >> Or just scan through the capabilities, and chain only the ones
> >> >> that we want to "Whitelist" and the rest are to be blacklisted.
> >> >> The rest can also have its values set to some bogus value (0xdeadbeef?)
> >> >> Perhaps only when built with 'debug=y'.
> >> >
> >> >
> >> > That sounds about right. Back when I first did the patch (in an old qemu)
> >> > there were no other capabilities on the piix4 host bridge so it was simple.
> >> > Not sure if other capabilities will be an issue now.
> >>
> >> It's still the case as for the IVB host bridge.
> >> And from what I can find from the datasheet for the Haswell, it's
> >> still the case.
> >>
> >> Note that the datasheet explicitly documents the offset of the
> >> CAPABILITY registers.
> >> I guess there will be code that rely on this offset that been publicly
> >> documented.
> >>
> >> Btw. Ross, now that you appears to be the original author (sorry for
> >> mess you up with Jean),
> >> could you also comment on my rework proposal? Jan believe the current
> >> form is not clean enough.
> >>
> >> Currently we use a whitelist of registers to pass-through.How do you
> >> come up with the current list?
> >> The shadow copy way appears to work for the current list.
> >
> > OK.
> >> But what if we are going to need some special registers that cannot be
> >> handled well? (e.g. has side effect for reading and cannot perform
> >> read-back?)
> >
> > Hopefully the i915 driver in Linux will help in figuring out which
> > ones of those are needed?
> I remember the vendor cap fix only helps windows guest.
How was that diagnosed? Perhaps that information can be part of the source
code to help in the future with diagnosiing which caps are needed and
which ones can be blacklisted?
> Linux guest just run happily without this.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2013-07-01 13:06 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 16:12 Patch series for IGD passthrough Rui Guo
2013-02-07 16:12 ` [PATCH 1/3] qemu-xen-trad/pt_msi_disable: do not clear all MSI flags Rui Guo
2013-02-07 16:12 ` [PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD passthrough Rui Guo
2013-02-07 16:30 ` Jan Beulich
2013-02-07 17:43 ` G.R.
2013-02-08 7:51 ` Jan Beulich
2013-05-21 15:39 ` G.R.
2013-05-24 4:02 ` G.R.
2013-02-08 11:30 ` Stefano Stabellini
2013-02-08 11:36 ` Jan Beulich
2013-02-08 11:48 ` Stefano Stabellini
2013-05-21 15:52 ` G.R.
2013-05-21 15:57 ` Jan Beulich
2013-02-07 16:12 ` [PATCH 3/3] qemu-xen-trad: IGD passthrough: Expose vendor specific pci cap on host bridge Rui Guo
2013-02-07 16:40 ` Jan Beulich
2013-02-07 17:38 ` G.R.
2013-02-08 7:56 ` Jan Beulich
2013-06-19 10:37 ` G.R.
2013-06-21 18:03 ` Konrad Rzeszutek Wilk
2013-06-25 14:08 ` Ross Philipson
2013-06-25 14:54 ` Konrad Rzeszutek Wilk
2013-06-25 15:01 ` Ross Philipson
2013-06-26 4:18 ` G.R.
2013-06-26 12:53 ` Konrad Rzeszutek Wilk
2013-06-26 17:26 ` Ross Philipson
2013-06-27 7:27 ` G.R.
2013-07-01 13:06 ` Konrad Rzeszutek Wilk [this message]
2013-07-15 16:06 ` Pasi Kärkkäinen
2013-07-15 17:47 ` Ross Philipson
2013-07-15 22:55 ` Pasi Kärkkäinen
2013-08-05 16:15 ` Pasi Kärkkäinen
2013-08-06 3:44 ` G.R.
2013-09-25 14:28 ` Pasi Kärkkäinen
2014-08-20 15:20 ` Pasi Kärkkäinen
2013-06-25 14:26 ` G.R.
2013-02-08 11:14 ` Patch series for IGD passthrough Stefano Stabellini
2013-03-20 17:17 ` Pasi Kärkkäinen
2013-04-15 20:48 ` Pasi Kärkkäinen
2013-04-16 10:56 ` George Dunlap
2013-04-16 15:59 ` Pasi Kärkkäinen
2013-04-18 11:48 ` Stefano Stabellini
2012-12-19 13:06 ` [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge " G.R.
2012-12-20 13:13 ` Stefano Stabellini
2013-02-22 18:05 ` Ian Jackson
2013-02-25 10:10 ` Jan Beulich
2013-02-25 11:24 ` Ian Jackson
2013-02-25 11:29 ` Jan Beulich
2013-02-25 12:49 ` Stefano Stabellini
2013-05-07 17:12 ` [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough [and 2 more messages] Ian Jackson
2013-05-09 13:17 ` Pasi Kärkkäinen
2013-05-10 9:12 ` Jan Beulich
2013-05-10 9:40 ` Pasi Kärkkäinen
2013-05-10 10:00 ` Ian Campbell
2013-05-10 10:09 ` George Dunlap
2013-05-10 10:33 ` Ian Campbell
2013-05-10 10:44 ` Pasi Kärkkäinen
2013-05-10 10:35 ` Jan Beulich
2013-02-25 16:46 ` [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough Ian Jackson
2013-04-18 11:47 ` Patch series " Stefano Stabellini
2013-05-03 15:14 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701130637.GA10934@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=Jean.guyader@gmail.com \
--cc=firemeteor@users.sourceforge.net \
--cc=ian.campbell@citrix.com \
--cc=ross.philipson@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).