From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [PATCH 18/18] PVH xen: introduce vmx_pvh.c Date: Wed, 3 Jul 2013 19:02:11 -0700 Message-ID: <20130703190211.38f3e8ca@mantra.us.oracle.com> References: <1372118507-16864-1-git-send-email-mukesh.rathor@oracle.com> <1372118507-16864-19-git-send-email-mukesh.rathor@oracle.com> <51C991F502000078000E04E5@nat28.tlf.novell.com> <20130627192818.2ba03853@mantra.us.oracle.com> <51CD770802000078000E1806@nat28.tlf.novell.com> <20130702184037.1277b5c8@mantra.us.oracle.com> <51D4184D02000078000E26F2@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51D4184D02000078000E26F2@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Wed, 03 Jul 2013 11:25:49 +0100 "Jan Beulich" wrote: > >>> On 03.07.13 at 03:40, Mukesh Rathor > >>> wrote: > > On Fri, 28 Jun 2013 10:44:08 +0100 > > "Jan Beulich" wrote: > > > >> >>> On 28.06.13 at 04:28, Mukesh Rathor > >> >>> wrote: > >> > On Tue, 25 Jun 2013 11:49:57 +0100 "Jan Beulich" > >> > wrote: > > ...... > >> And btw., looking at that patch again I'm also getting the > >> impression that the GS base handling in that function is lacking > >> consideration of VGCF_in_kernel. > > > > I still fail to see what VGCF_in_kernel has to do with GS base for > > PVH guest. The flag should be irrelevant for PVH IMO. Can you kindly > > elaborate a bit? > > VGCF_in_kernel specifies whether a guest wants to start its vCPU > in user of kernel mode (why the interface permits that is another > question, but you have to play by what is there). My understanding is because of the trap bounce, we need to keep track of kernel/user mode 64bit PV guest in ring3. Fortunatley, nothing of that for PVH. thanks mukesh