xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com,
	Jan Beulich <JBeulich@suse.com>,
	Michael Opdenacker <michael.opdenacker@free-electrons.com>,
	x86@kernel.org, Paul Bolle <pebolle@tiscali.nl>,
	virtualization@lists.linux-foundation.org, mingo@redhat.com,
	Matt Wilson <msw@amazon.com>, "H. Peter Anvin" <hpa@zytor.com>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen: remove unused Kconfig parameter
Date: Tue, 9 Jul 2013 13:19:09 -0400	[thread overview]
Message-ID: <20130709171909.GA25586@phenom.dumpdata.com> (raw)
In-Reply-To: <20130709150554.GA27579@pd.tnic>

On Tue, Jul 09, 2013 at 05:05:54PM +0200, Borislav Petkov wrote:
> On Tue, Jul 09, 2013 at 10:48:40AM -0400, Konrad Rzeszutek Wilk wrote:
> > Then that should be discussed on grub2 to remove said check and modify
> > the code so that it can properly work without regression.
> 
> Actually, the kernel patch removing that symbol should be applied so
> that grub2 breaks faster. One can't possibly rely on kernel internals
> for anything, as it is insanely insane (yep, the tautology is on purpose
> :-)).

I am not sure why you are advocating that path.

My thinking is that what should be done to have some sense of history
is that the patch in GRUB to not rely on kernel internals should be done.
Then that git commit of that tree should be mentioned in this kernel patch.

This way one can nicely follow the trail of changes and see what the
interdependencies are (or rather that they have been removed).

I wouldn't want GRUB2 to have regressions and stop generating the proper
menu options. That smells of userspace regressions and I am not too
keen to have Linus point this out to me.

Once that is done we can follow up on this patch and perhaps also
nicely convience the initial author of this patch to look at removing the
CONFIG_XEN_DOM0 and replacing them with the two other CONFIG options
that Jan and me have been discussing.

  parent reply	other threads:[~2013-07-09 17:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08  6:28 [PATCH] xen: remove unused Kconfig parameter Michael Opdenacker
2013-07-08 19:28 ` Konrad Rzeszutek Wilk
2013-07-08 19:34   ` [Xen-devel] " Matt Wilson
2013-07-08 20:29     ` H. Peter Anvin
2013-07-08 20:58       ` Borislav Petkov
2013-07-08 23:35         ` Paul Bolle
2013-07-09  0:26           ` Konrad Rzeszutek Wilk
2013-07-09  7:41             ` Jan Beulich
2013-07-09 14:48               ` Konrad Rzeszutek Wilk
2013-07-09 14:54                 ` Jan Beulich
2013-07-09 15:05                 ` Borislav Petkov
2013-07-09 15:09                   ` H. Peter Anvin
2013-07-09 17:19                   ` Konrad Rzeszutek Wilk [this message]
2013-07-09 20:01                     ` Borislav Petkov
2013-07-09 20:40                       ` Konrad Rzeszutek Wilk
2013-07-09 20:57                         ` Borislav Petkov
2013-07-09 22:34                   ` Sander Eikelenboom
2013-07-10  3:20                     ` Borislav Petkov
2013-07-10  3:55                     ` H. Peter Anvin
2013-07-10  6:19                     ` Matt Wilson
2013-07-10  7:41                       ` Sander Eikelenboom
2013-07-10 14:46                         ` Konrad Rzeszutek Wilk
2013-07-11 10:08             ` Paul Bolle
2013-07-11 17:57               ` H. Peter Anvin
2013-07-11 18:13                 ` Paul Bolle
2013-07-11 18:24                   ` Konrad Rzeszutek Wilk
2013-07-11 21:13                 ` Geert Uytterhoeven
2013-07-08 20:13   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130709171909.GA25586@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.opdenacker@free-electrons.com \
    --cc=mingo@redhat.com \
    --cc=msw@amazon.com \
    --cc=pebolle@tiscali.nl \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).