From: David Miller <davem@davemloft.net>
To: annie.li@oracle.com
Cc: xen-devel@lists.xensource.com, wei.liu2@citrix.com,
Ian.Campbell@citrix.com, netdev@vger.kernel.org, msw@amazon.com
Subject: Re: [Xen-devel] [PATCH v2 1/1] xen/netback: correctly calculate required slots of skb.
Date: Thu, 11 Jul 2013 12:04:19 -0700 (PDT) [thread overview]
Message-ID: <20130711.120419.1262676305594990714.davem@davemloft.net> (raw)
In-Reply-To: <51DE1D1A.7020007@oracle.com>
From: annie li <annie.li@oracle.com>
Date: Thu, 11 Jul 2013 10:48:58 +0800
> On 2013-7-11 10:18, David Miller wrote:
>> I prefer MAX_BUFFER_OFFSET because it gives the indication that
>> what this value represents is the modulus upon which we must chop up
>> RX buffers in this driver.
>
> Would PAGE_SIZE be more straight? MAX_BUFFER_OFFSET gives an idea of
> offset instead of length.
> Anyway, making it consistent is a good idea.
I think the choice is a tossup, and less important than consistency.
next prev parent reply other threads:[~2013-07-11 19:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 9:15 [PATCH v2 1/1] xen/netback: correctly calculate required slots of skb Annie Li
2013-07-11 2:18 ` David Miller
2013-07-11 2:48 ` [Xen-devel] " annie li
2013-07-11 19:04 ` David Miller [this message]
2013-07-11 8:11 ` Ian Campbell
2013-07-11 8:34 ` annie li
2013-07-11 9:47 ` Ian Campbell
2013-07-11 10:46 ` Annie
2013-07-11 10:59 ` Annie
2013-07-11 11:12 ` [Xen-devel] " Ian Campbell
2013-07-11 13:35 ` annie li
2013-07-11 20:03 ` David Miller
2013-07-11 21:12 ` [Xen-devel] " Wei Liu
2013-07-16 9:00 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711.120419.1262676305594990714.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=msw@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).