xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Matt Wilson <msw@amazon.com>
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/xl: Add 'xen_version' to `xl info`
Date: Thu, 11 Jul 2013 10:49:24 -0700	[thread overview]
Message-ID: <20130711174922.GA7435@u109add4315675089e695.ant.amazon.com> (raw)
In-Reply-To: <51DE7914.7070403@eu.citrix.com>

On Thu, Jul 11, 2013 at 10:21:24AM +0100, George Dunlap wrote:
> On 11/07/13 10:10, Andrew Cooper wrote:

[...]

> >
> >Even with this however, my original point still stands.  Getting the
> >version number is awkward.
> 
> Is there actually a reason to print it separately at all?  Why not
> replace the individual lines with the unified line?

Please don't do that. I'm sure that there are scripts out there that
stitch together the parts into a version string. They'll break if we
remove the parts.

--msw

      parent reply	other threads:[~2013-07-11 17:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 16:46 [PATCH] tools/xl: Add 'xen_version' to `xl info` Andrew Cooper
2013-07-10 17:07 ` Matt Wilson
2013-07-12 16:40   ` [PATCH] tools/xl: Add 'xen_version' to `xl info` [and 3 more messages] Ian Jackson
2013-07-11  9:02 ` [PATCH] tools/xl: Add 'xen_version' to `xl info` George Dunlap
2013-07-11  9:10   ` Andrew Cooper
2013-07-11  9:21     ` George Dunlap
2013-07-11  9:34       ` Andrew Cooper
2013-07-11 17:49       ` Matt Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130711174922.GA7435@u109add4315675089e695.ant.amazon.com \
    --to=msw@amazon.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).