Re: [PATCH 2/2] xen: arm: drop LDFLAGS_DIRECT emulation specification.

[Tim Deegan <tim@xen.org>]

At 13:14 +0100 on 18 Jul (1374153286), Ian Campbell wrote:
> Ping?
> 
> On Fri, 2013-04-26 at 11:58 +0100, Ian Campbell wrote:
> > The current -maarch64elf fails when cross-building arm64 on Ubuntu Raring due
> > to a missing file "ldscripts/aarch64elf.xr". This is undoubtedly an Ubuntu gcc
> > bug, hwever when investigating I found that this option was not necessary at
> > all since we provide an explicit linker script when linking the hypervisor
> > (AFAICT all -m<foo> does is override the default linker script).
> > 
> > LDFLAGS_DIRECT is also used when linking the intermediate built-in.o files but
> > -m<emulatin> is not needed for this since it isn't linking the final image and
> > we are calling the linker with the correct, cross if necessary, name.
> > 
> > However it does appear to be potentially useful to supply -EL in both cases to
> > ensure that we get little endian images. (I just happened to spot that Linux
> > does this, for both arm and arm64, although I expect we are unlikely to trip
> > over such toolchains these days).
> > 
> > Tested with cross-builds of arm32 and arm64 as well as a native arm32 build.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Tim Deegan <tim@xen.org>