From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 2/2] xen: arm: drop LDFLAGS_DIRECT emulation specification. Date: Thu, 18 Jul 2013 18:09:30 +0100 Message-ID: <20130718170930.GD94768@ocelot.phlegethon.org> References: <1366973912.3142.67.camel@zakaz.uk.xensource.com> <1366973927-23898-2-git-send-email-ian.campbell@citrix.com> <1374149686.26728.75.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1374149686.26728.75.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org At 13:14 +0100 on 18 Jul (1374153286), Ian Campbell wrote: > Ping? > > On Fri, 2013-04-26 at 11:58 +0100, Ian Campbell wrote: > > The current -maarch64elf fails when cross-building arm64 on Ubuntu Raring due > > to a missing file "ldscripts/aarch64elf.xr". This is undoubtedly an Ubuntu gcc > > bug, hwever when investigating I found that this option was not necessary at > > all since we provide an explicit linker script when linking the hypervisor > > (AFAICT all -m does is override the default linker script). > > > > LDFLAGS_DIRECT is also used when linking the intermediate built-in.o files but > > -m is not needed for this since it isn't linking the final image and > > we are calling the linker with the correct, cross if necessary, name. > > > > However it does appear to be potentially useful to supply -EL in both cases to > > ensure that we get little endian images. (I just happened to spot that Linux > > does this, for both arm and arm64, although I expect we are unlikely to trip > > over such toolchains these days). > > > > Tested with cross-builds of arm32 and arm64 as well as a native arm32 build. > > > > Signed-off-by: Ian Campbell Acked-by: Tim Deegan