From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [V10 PATCH 00/23]PVH xen: Phase I, Version 10 patches... Date: Fri, 26 Jul 2013 17:59:05 -0700 Message-ID: <20130726175905.69c4861d@mantra.us.oracle.com> References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com> <20130725163928.GE87903@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130725163928.GE87903@ocelot.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Xen-devel@lists.xensource.com, keir.xen@gmail.com List-Id: xen-devel@lists.xenproject.org On Thu, 25 Jul 2013 17:39:28 +0100 Tim Deegan wrote: > Hi, ... > #19 is probably OK for correctness, though I haven't reviewed the VMCS > settings in enough detail to be sure they're complete. My main > reservation is that it seems to duplicate a bunch of code from the > HVM VMCS setup. Forgot to respond to this. I factored out some common code into vmx_set_common_host_vmcs_fields. Other lets just leave it, otherwise it clutters the existing function way too much with if (PVH) statements. thanks Mukesh