From: Ingo Molnar <mingo@kernel.org>
To: Gleb Natapov <gleb@redhat.com>
Cc: jeremy@goop.org, x86@kernel.org, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, peterz@infradead.org,
drjones@redhat.com, virtualization@lists.linux-foundation.org,
andi@firstfloor.org, hpa@zytor.com,
stefano.stabellini@eu.citrix.com, xen-devel@lists.xensource.com,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
mingo@redhat.com, habanero@linux.vnet.ibm.com, riel@redhat.com,
konrad.wilk@oracle.com, ouyang@cs.pitt.edu, avi.kivity@gmail.com,
tglx@linutronix.de, chegu_vinod@hp.com, gregkh@suse.de,
linux-kernel@vger.kernel.org, srivatsa.vaddagiri@gmail.com,
attilio.rao@citrix.com, pbonzini@redhat.com,
torvalds@linux-foundation.org
Subject: Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor
Date: Mon, 5 Aug 2013 11:46:03 +0200 [thread overview]
Message-ID: <20130805094603.GA29303@gmail.com> (raw)
In-Reply-To: <20130802095406.GB30072@redhat.com>
* Gleb Natapov <gleb@redhat.com> wrote:
> On Fri, Aug 02, 2013 at 11:25:39AM +0200, Ingo Molnar wrote:
> > > Ingo,
> > >
> > > Do you have any concerns reg this series? please let me know if this
> > > looks good now to you.
> >
> > I'm inclined to NAK it for excessive quotation - who knows how many
> > people left the discussion in disgust? Was it done to drive away as
> > many reviewers as possible?
> >
> > Anyway, see my other reply, the measurement results seem hard to
> > interpret and inconclusive at the moment.
>
> That result was only for patch 18 of the series, not pvspinlock in
> general.
Okay - I've re-read the performance numbers and they are impressive, so no
objections from me.
The x86 impact seems to be a straightforward API change, with most of the
changes on the virtualization side. So:
Acked-by: Ingo Molnar <mingo@kernel.org>
I guess you'd want to carry this in the KVM tree or so - maybe in a
separate branch because it changes Xen as well?
Thanks,
Ingo
next prev parent reply other threads:[~2013-08-05 9:46 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 6:16 [PATCH RFC V11 0/18] Paravirtualized ticket spinlocks Raghavendra K T
2013-07-22 6:16 ` [PATCH RFC V11 1/18] x86/spinlock: Replace pv spinlocks with pv ticketlocks Raghavendra K T
2013-07-22 6:17 ` [PATCH RFC V11 2/18] x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks Raghavendra K T
2013-07-22 6:17 ` [PATCH RFC V11 3/18] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-07-22 6:17 ` [PATCH RFC V11 4/18] xen: Defer spinlock setup until boot CPU setup Raghavendra K T
2013-07-22 6:17 ` [PATCH RFC V11 5/18] xen/pvticketlock: Xen implementation for PV ticket locks Raghavendra K T
2013-07-22 6:17 ` [PATCH RFC V11 6/18] xen/pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks Raghavendra K T
2013-07-22 6:18 ` [PATCH RFC V11 7/18] x86/pvticketlock: Use callee-save for lock_spinning Raghavendra K T
2013-07-22 6:18 ` [PATCH RFC V11 8/18] x86/pvticketlock: When paravirtualizing ticket locks, increment by 2 Raghavendra K T
2013-07-22 6:18 ` [PATCH RFC V11 9/18] jump_label: Split out rate limiting from jump_label.h Raghavendra K T
2013-07-22 6:18 ` [PATCH RFC V11 10/18] x86/ticketlock: Add slowpath logic Raghavendra K T
2013-07-22 6:19 ` [PATCH RFC V11 11/18] xen/pvticketlock: Allow interrupts to be enabled while blocking Raghavendra K T
2013-07-22 6:19 ` [PATCH RFC V11 12/18] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks Raghavendra K T
2013-07-22 6:19 ` [PATCH RFC V11 13/18] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration Raghavendra K T
2013-07-22 6:20 ` [PATCH RFC V11 14/18] kvm guest : Add configuration support to enable debug information for KVM Guests Raghavendra K T
2013-07-22 6:20 ` [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2013-07-23 15:07 ` Gleb Natapov
2013-07-24 9:24 ` [PATCH RESEND " Raghavendra K T
2013-07-24 9:45 ` [PATCH " Raghavendra K T
2013-07-24 10:39 ` Gleb Natapov
2013-07-24 12:00 ` Raghavendra K T
2013-07-24 12:06 ` Gleb Natapov
2013-07-24 12:36 ` Raghavendra K T
2013-07-25 9:17 ` Raghavendra K T
2013-07-25 9:15 ` Gleb Natapov
2013-07-25 9:38 ` Raghavendra K T
2013-07-30 16:43 ` Raghavendra K T
2013-07-31 6:24 ` Gleb Natapov
2013-08-01 7:38 ` Raghavendra K T
2013-08-01 7:45 ` Gleb Natapov
2013-08-01 9:04 ` Raghavendra K T
2013-08-02 3:22 ` Raghavendra K T
2013-08-02 9:23 ` Ingo Molnar
2013-08-02 9:44 ` Raghavendra K T
2013-08-02 9:25 ` Ingo Molnar
2013-08-02 9:54 ` Gleb Natapov
2013-08-02 10:57 ` Raghavendra K T
2013-08-05 9:46 ` Ingo Molnar [this message]
2013-08-05 10:42 ` Raghavendra K T
[not found] ` <20130805095901.GL2258@redhat.com>
2013-08-05 13:52 ` Ingo Molnar
2013-08-05 14:05 ` Paolo Bonzini
2013-08-05 14:39 ` Raghavendra K T
2013-08-05 14:45 ` Paolo Bonzini
2013-08-05 15:37 ` Konrad Rzeszutek Wilk
2013-07-22 6:20 ` [PATCH RFC V11 16/18] kvm hypervisor : Simplify kvm_for_each_vcpu with kvm_irq_delivery_to_apic Raghavendra K T
2013-07-22 6:20 ` [PATCH RFC V11 17/18] Documentation/kvm : Add documentation on Hypercalls and features used for PV spinlock Raghavendra K T
2013-07-22 6:20 ` [PATCH RFC V11 18/18] kvm hypervisor: Add directed yield in vcpu block path Raghavendra K T
2013-07-22 19:36 ` [PATCH RFC V11 0/18] Paravirtualized ticket spinlocks Konrad Rzeszutek Wilk
2013-07-23 2:50 ` Raghavendra K T
2013-08-05 22:50 ` H. Peter Anvin
2013-08-06 2:50 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805094603.GA29303@gmail.com \
--to=mingo@kernel.org \
--cc=andi@firstfloor.org \
--cc=attilio.rao@citrix.com \
--cc=avi.kivity@gmail.com \
--cc=chegu_vinod@hp.com \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=gregkh@suse.de \
--cc=habanero@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ouyang@cs.pitt.edu \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=srivatsa.vaddagiri@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).