From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V10 PATCH 09/23] PVH xen: introduce
 pvh_set_vcpu_info() and vmx_pvh_set_vcpu_info()
Date: Wed, 7 Aug 2013 18:05:49 -0700
Message-ID: <20130807180549.46941f85@mantra.us.oracle.com>
References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
	<1374631171-15224-10-git-send-email-mukesh.rathor@oracle.com>
	<51FFA43702000078000E936E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1V7Eft-00057D-Jg
	for xen-devel@lists.xenproject.org; Thu, 08 Aug 2013 01:05:57 +0000
In-Reply-To: <51FFA43702000078000E936E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir.xen@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 05 Aug 2013 12:10:15 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 24.07.13 at 03:59, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > +int vmx_pvh_set_vcpu_info(struct vcpu *v, struct
> > vcpu_guest_context *ctxtp) +{
> > +    if ( v->vcpu_id == 0 )
> > +        return 0;
> > +
> > +    if ( !(ctxtp->flags & VGCF_in_kernel) )
> > +        return -EINVAL;
> > +
> > +    vmx_vmcs_enter(v);
> > +    __vmwrite(GUEST_GDTR_BASE, ctxtp->gdt.pvh.addr);
> > +    __vmwrite(GUEST_GDTR_LIMIT, ctxtp->gdt.pvh.limit);
> > +    __vmwrite(GUEST_LDTR_BASE, ctxtp->ldt_base);
> > +    __vmwrite(GUEST_LDTR_LIMIT, ctxtp->ldt_ents);
> 
> Just noticed: Aren't you mixing up entries and bytes here?

Right:

__vmwrite(GUEST_LDTR_LIMIT, (ctxtp->ldt_ents * 8 - 1) );

Any formatting issues here? I don't see in coding style, and see
both code where there is a space around '*' and not.

Also, when setting the limit, do we need to worry about the G flag?
or for that matter, D/B whether segment is growing up or down?
It appears we don't need to worry about that for LDT, but not sure
reading the SDMs..

thanks,
Mukesh