From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V10 PATCH 10/23] PVH xen: domain create,
 context switch related code changes
Date: Wed, 7 Aug 2013 18:42:41 -0700
Message-ID: <20130807184241.6f536448@mantra.us.oracle.com>
References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
	<1374631171-15224-11-git-send-email-mukesh.rathor@oracle.com>
	<CAFLBxZaXWUT9wQ=okSQKc+yQG53Ft6VtYmJOA6qHJZ2DWOVA5g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZaXWUT9wQ=okSQKc+yQG53Ft6VtYmJOA6qHJZ2DWOVA5g@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, "keir.xen@gmail.com" <keir.xen@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 7 Aug 2013 11:48:26 +0100
George Dunlap <George.Dunlap@eu.citrix.com> wrote:

> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor
> <mukesh.rathor@oracle.com> wrote:
..........
> > +
> >          v->arch.guest_table = pagetable_from_page(cr3_page);
> > -        if ( c.nat->ctrlreg[1] )
> > +        if ( c.nat->ctrlreg[1] && !is_pvh_vcpu(v) )
> >          {
> >              cr3_gfn = xen_cr3_to_pfn(c.nat->ctrlreg[1]);
> >              cr3_page = get_page_from_gfn(d, cr3_gfn, NULL,
> > P2M_ALLOC); @@ -954,6 +965,13 @@ int arch_set_info_guest(
> >
> >      update_cr3(v);
> >
> > +    if ( is_pvh_vcpu(v) )
> > +    {
> > +        /* Set VMCS fields. */
> > +        if ( (rc = pvh_set_vcpu_info(v, c.nat)) != 0 )
> > +            return rc;
> > +    }
> 
> BTW, would it make sense to pull the code above, which sets FS and GS
> for PV guests into a separate function, and then do something like the
> following?
> 
>  is_pv_vcpu(v) ?
>    pv_set_vcpu_info() :
>    pvh_set_vcpu_info();

Perhaps! But, these patches have been out for about 7 months now, and
are tested by us and Andrew for PV and HVM regressions. I prefer not 
changing common code at this point, unless buggy. May be we can do an
incremental change later if you really want this function to be
re-org'd.

thanks
mukesh