From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, x86@kernel.org, jeremy@goop.org,
konrad.wilk@oracle.com, gleb@redhat.com, pbonzini@redhat.com,
gregkh@suse.de, peterz@infradead.org, tglx@linutronix.de,
agraf@suse.de, riel@redhat.com, avi.kivity@gmail.com,
habanero@linux.vnet.ibm.com, chegu_vinod@hp.com,
ouyang@cs.pitt.edu, drjones@redhat.com, attilio.rao@citrix.com,
linux-doc@vger.kernel.org, torvalds@linux-foundation.org,
kvm@vger.kernel.org, andi@firstfloor.org,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org,
stefano.stabellini@eu.citrix.com, mtosatti@redhat.com,
srivatsa.vaddagiri@gmail.com,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Suzuki Poulose <suzuki@in.ibm.com>
Subject: Re: [PATCH RESEND V13 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor
Date: Tue, 13 Aug 2013 18:55:52 +0200 [thread overview]
Message-ID: <20130813165552.GA6795@gmail.com> (raw)
In-Reply-To: <520A620B.6070702@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> Raghavendra...
>
> Even with this latest patch this branch is broken:
>
> :(.discard+0x6108): multiple definition of `__pcpu_unique_lock_waiting'
> arch/x86/xen/built-in.o:(.discard+0x23): first defined here
> CC drivers/firmware/google/gsmi.o
> arch/x86/kernel/built-in.o:(.discard+0x6108): multiple definition of
> `__pcpu_unique_lock_waiting'
> arch/x86/xen/built-in.o:(.discard+0x23): first defined here
> CC sound/core/seq/oss/seq_oss_init.o
>
> This is trivially reproducible by doing a build with "make allyesconfig".
>
> Please fix and *verify* it is fixed before resubmitting.
>
> I will be away so Ingo will have to handle the resubmission.
Would be nice to have a delta fix patch against tip:x86/spinlocks, which
I'll then backmerge into that series via rebasing it.
Thanks,
Ingo
next prev parent reply other threads:[~2013-08-13 16:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 14:21 [PATCH V13 00/14] Paravirtualized ticket spinlocks Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 01/14] x86/spinlock: Replace pv spinlocks with pv ticketlocks Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 02/14] x86/ticketlock: Don't inline _spin_unlock when using paravirt spinlocks Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 03/14] x86/ticketlock: Collapse a layer of functions Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 04/14] xen: Defer spinlock setup until boot CPU setup Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 05/14] xen/pvticketlock: Xen implementation for PV ticket locks Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 06/14] xen/pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 07/14] x86/pvticketlock: Use callee-save for lock_spinning Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 08/14] x86/pvticketlock: When paravirtualizing ticket locks, increment by 2 Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 09/14] jump_label: Split jumplabel ratelimit Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 10/14] x86/ticketlock: Add slowpath logic Raghavendra K T
2013-08-09 14:21 ` [PATCH V13 11/14] xen/pvticketlock: Allow interrupts to be enabled while blocking Raghavendra K T
2013-08-09 14:22 ` [PATCH V13 12/14] kvm uapi: Add KICK_CPU and PV_UNHALT definition to uapi Raghavendra K T
2013-08-09 14:22 ` [PATCH V13 13/14] kvm guest : Add configuration support to enable debug information for KVM Guests Raghavendra K T
2013-08-09 14:22 ` [PATCH V13 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2013-08-10 19:38 ` [PATCH RESEND " Raghavendra K T
2013-08-13 16:42 ` H. Peter Anvin
2013-08-13 16:55 ` Ingo Molnar [this message]
2013-08-13 20:02 ` [PATCH delta " Raghavendra K T
2013-08-13 20:00 ` Jeremy Fitzhardinge
2013-08-13 20:27 ` Raghavendra K T
2013-08-14 9:50 ` Raghavendra K T
2013-08-11 5:35 ` [PATCH RESEND " Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813165552.GA6795@gmail.com \
--to=mingo@kernel.org \
--cc=agraf@suse.de \
--cc=andi@firstfloor.org \
--cc=attilio.rao@citrix.com \
--cc=avi.kivity@gmail.com \
--cc=chegu_vinod@hp.com \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=gregkh@suse.de \
--cc=habanero@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=ouyang@cs.pitt.edu \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=srivatsa.vaddagiri@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suzuki@in.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vatsa@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).