From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V10 PATCH 19/23] PVH xen: vmcs related changes
Date: Mon, 19 Aug 2013 15:21:52 -0700
Message-ID: <20130819152152.7ed4fad7@mantra.us.oracle.com>
References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
	<1374631171-15224-20-git-send-email-mukesh.rathor@oracle.com>
	<CAFLBxZZDKrAgG-qniVMJDz5GDBzvpDtw782VEkGWKD15x-QhJQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZZDKrAgG-qniVMJDz5GDBzvpDtw782VEkGWKD15x-QhJQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, "keir.xen@gmail.com" <keir.xen@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 19 Aug 2013 17:00:53 +0100
George Dunlap <George.Dunlap@eu.citrix.com> wrote:

> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor
> <mukesh.rathor@oracle.com> wrote:
> > @@ -1294,6 +1534,9 @@ void vmx_do_resume(struct vcpu *v)
> >          hvm_asid_flush_vcpu(v);
> >      }
> >
> > +    if ( is_pvh_vcpu(v) )
> > +        reset_stack_and_jump(vmx_asm_do_vmentry);
> > +
> 
> This skips the debugger stuff, but also skips hvm_do_resume().
> hvm_do_resume() has timer and ioreq stuff that's not needed for PVH,
> but it also has code to "Inject a pending hw/sw trap".  Might that
> code not be needed?

We inject exceptions directly for PVH, like in vmxit_int3() if the
exception doesn't belong to supported debugger, we inject it into the
guest. PVH supports gdbsx debugger, but not the external debugger which
seems to set the vector to be injected (for HVMOP_inject_trap).

-Mukesh