From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V10 PATCH 19/23] PVH xen: vmcs related changes
Date: Mon, 19 Aug 2013 15:38:32 -0700
Message-ID: <20130819153832.591d5266@mantra.us.oracle.com>
References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
	<1374631171-15224-20-git-send-email-mukesh.rathor@oracle.com>
	<CAFLBxZZDKrAgG-qniVMJDz5GDBzvpDtw782VEkGWKD15x-QhJQ@mail.gmail.com>
	<CAFLBxZbY4G_hhOxPwmuUihBxbPpB8GKGkqFu15fxNgh5FXDEgA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZbY4G_hhOxPwmuUihBxbPpB8GKGkqFu15fxNgh5FXDEgA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Tim Deegan <tim@xen.org>, "keir.xen@gmail.com" <keir.xen@gmail.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 19 Aug 2013 17:03:11 +0100
George Dunlap <George.Dunlap@eu.citrix.com> wrote:

> On Mon, Aug 19, 2013 at 5:00 PM, George Dunlap
> <George.Dunlap@eu.citrix.com> wrote:
> > On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor
> > <mukesh.rathor@oracle.com> wrote:
> >> @@ -1294,6 +1534,9 @@ void vmx_do_resume(struct vcpu *v)
> >>          hvm_asid_flush_vcpu(v);
> >>      }
> >>
> >> +    if ( is_pvh_vcpu(v) )
> >> +        reset_stack_and_jump(vmx_asm_do_vmentry);
> >> +
> >
> > This skips the debugger stuff, but also skips hvm_do_resume().
> > hvm_do_resume() has timer and ioreq stuff that's not needed for PVH,
> > but it also has code to "Inject a pending hw/sw trap".  Might that
> > code not be needed?
> 
> hvm_do_resume() also has check_wakeup_from_wait() -- that seems like
> it would apply to PVH VMs as well, no?

Right, to support VMI, virt machine introspection, we'd need that. I
should add that to the list of things TBD for PVH. It may be as simple
as just doing that for PVH, but I'd need to study VMI in bit more
details.

thanks,
mukesh