From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V10 PATCH 14/23] PVH xen: additional changes to
 support PVH guest creation and execution.
Date: Tue, 20 Aug 2013 14:32:00 -0700
Message-ID: <20130820143200.5f631769@mantra.us.oracle.com>
References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
	<1374631171-15224-15-git-send-email-mukesh.rathor@oracle.com>
	<CAFLBxZZ8DPWM2ORfskX=HgKOg70FFOVn3MNC5zD+p8q1_HJYdA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZZ8DPWM2ORfskX=HgKOg70FFOVn3MNC5zD+p8q1_HJYdA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, "keir.xen@gmail.com" <keir.xen@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 20 Aug 2013 15:13:10 +0100
George Dunlap <George.Dunlap@eu.citrix.com> wrote:

> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor
> <mukesh.rathor@oracle.com> wrote:
> > diff --git a/xen/arch/x86/mm/hap/hap.c b/xen/arch/x86/mm/hap/hap.c
> > index bff05d9..19a085c 100644
> > --- a/xen/arch/x86/mm/hap/hap.c
> > +++ b/xen/arch/x86/mm/hap/hap.c
> > @@ -639,7 +639,9 @@ static void hap_update_cr3(struct vcpu *v, int
> > do_locking) const struct paging_mode *
> >  hap_paging_get_mode(struct vcpu *v)
> >  {
> > -    return !hvm_paging_enabled(v)   ? &hap_paging_real_mode :
> > +    /* PVH 32bitfixme. */
> > +    return is_pvh_vcpu(v)        ? &hap_paging_long_mode :
> > +        !hvm_paging_enabled(v)   ? &hap_paging_real_mode :
> >          hvm_long_mode_enabled(v) ? &hap_paging_long_mode :
> >          hvm_pae_enabled(v)       ? &hap_paging_pae_mode  :
> >                                     &hap_paging_protected_mode;
> 
> This shouldn't be necessary, right?  The PVH code should ensure that
> for 64-bit PVH guests, hvm_long_mode_enabled() is always true, right?

Right, 64bit PVH always will be in long mode. However, with 32bit PVH,
this check will change, so best to leave it here.

thanks
mukesh