From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V10 PATCH 18/23] PVH xen: add hypercall support
 for PVH
Date: Tue, 20 Aug 2013 14:41:09 -0700
Message-ID: <20130820144109.442f8f9f@mantra.us.oracle.com>
References: <1374631171-15224-1-git-send-email-mukesh.rathor@oracle.com>
	<1374631171-15224-19-git-send-email-mukesh.rathor@oracle.com>
	<CAFLBxZb0c6=a28GzMHbKV1YjHuQ-dWRTW_XcDjY0jYn_tvo54w@mail.gmail.com>
	<20130807191213.0f51cf5c@mantra.us.oracle.com>
	<520362E7.9070000@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <520362E7.9070000@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, "keir.xen@gmail.com" <keir.xen@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 8 Aug 2013 10:20:39 +0100
George Dunlap <george.dunlap@eu.citrix.com> wrote:

> On 08/08/13 03:12, Mukesh Rathor wrote:
> > On Wed, 7 Aug 2013 17:43:54 +0100
> > George Dunlap <George.Dunlap@eu.citrix.com> wrote:
> >
> >> On Wed, Jul 24, 2013 at 2:59 AM, Mukesh Rathor
> >> <mukesh.rathor@oracle.com> wrote:
....
> >>> +/* PVH 32bitfixme. */
> >>> +static hvm_hypercall_t *const
> >>> pvh_hypercall64_table[NR_hypercalls] = {
> >>> +    HYPERCALL(platform_op),
> >>> +    HYPERCALL(memory_op),
> >>> +    HYPERCALL(xen_version),
> >>> +    HYPERCALL(console_io),
> >>> +    [ __HYPERVISOR_grant_table_op ]  = (hvm_hypercall_t
> >>> *)hvm_grant_table_op,
> >>> +    [ __HYPERVISOR_vcpu_op ]         = (hvm_hypercall_t
> >>> *)hvm_vcpu_op,
> >>> +    HYPERCALL(mmuext_op),
> >>> +    HYPERCALL(xsm_op),
> >>> +    HYPERCALL(sched_op),
> >>> +    HYPERCALL(event_channel_op),
> >>> +    [ __HYPERVISOR_physdev_op ]      = (hvm_hypercall_t
> >>> *)hvm_physdev_op,
> >>> +    HYPERCALL(hvm_op),
> >>> +    HYPERCALL(sysctl),
> >>> +    HYPERCALL(domctl)
> >>> +};
> >> It would be nice if this list were in the same order as the other
> >> lists, so that it is easy to figure out what calls are common and
> >> what calls are different.
> > These are ordered by the hcall number, and assists in the debug.
> 
> That makes sense.  What about adding a "prep" patch which
> re-organizes the other lists by hcall number?  I'm not particular
> about which order, I just think they should be the same.

Jan is going to redo this anyways, so I'm gonna leave as is.

thanks,
mukesh