Re: [V11 PATCH 19/21] PVH xen: VMX support of PVH guest creation/destruction

[Mukesh Rathor <mukesh.rathor@oracle.com>]

On Fri, 23 Aug 2013 10:14:11 +0100
"Jan Beulich" <JBeulich@suse.com> wrote:

> >>> On 23.08.13 at 03:19, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> >  static void vmx_update_guest_cr(struct vcpu *v, unsigned int cr)
> >  {
> > +    /*
> > +     * PVH guest never causes CR3 write vmexit. This is called
> > during the guest
> > +     * setup.
> > +     */
> > +    if ( is_pvh_vcpu(v) && cr != 3 )
> > +    {
> > +        printk(XENLOG_G_ERR
> > +               "PVH: d%d v%d unexpected cr%d update at rip:%lx\n",
> > +               v->domain->domain_id, v->vcpu_id, cr,
> > __vmread(GUEST_RIP));
> > +        return;
> > +    }
> > +
> >      vmx_vmcs_enter(v);
> >  
> >      switch ( cr )
> > @@ -1183,7 +1195,7 @@ static void vmx_update_guest_cr(struct vcpu
> > *v, unsigned int cr) /* CR2 is updated in exit stub. */
> >          break;
> >      case 3:
> > -        if ( paging_mode_hap(v->domain) )
> > +        if ( paging_mode_hap(v->domain) && !is_pvh_vcpu(v) )
> 
> This seems redundant with the check above?

We are trying to avoid unnecessary call to vmx_load_pdptrs(v).

-Mukesh