From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian.Jackson@eu.citrix.com
Subject: Re: [V1 PATCH 3/5] PVH xen tools: libxl changes to create a PVH guest.
Date: Thu, 5 Sep 2013 18:23:27 -0700 [thread overview]
Message-ID: <20130905182327.6cb14c15@mantra.us.oracle.com> (raw)
In-Reply-To: <1378375381.14745.14.camel@kazak.uk.xensource.com>
On Thu, 5 Sep 2013 11:03:01 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Wed, 2013-09-04 at 18:32 -0700, Mukesh Rathor wrote:
> > Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> > ---
> > tools/libxl/libxl_create.c | 12 ++++++++++++
> > tools/libxl/libxl_dom.c | 5 ++++-
> > tools/libxl/libxl_internal.h | 1 +
> > tools/libxl/libxl_types.idl | 1 +
> > tools/libxl/libxl_x86.c | 4 +++-
> > tools/libxl/xl_cmdimpl.c | 1 +
>
> Please also modify libxl.h to add a suitable LIBXL_HAVE_xxx #define as
> described in the big comment about API compatibility.
Ah, not sure whey LIBXL_API_VERSION can't be used in this case. But,
anyways, maybe something like:
/*
* LIBXL_HAVE_PVH_SUPPORT or LIBXL_HAVE_PVH_EXTENSIONS or
* LIBXL_HAVE_PVH_FEATURE....
*
* If this is defined, the library supports PVH extensions for building a
* PV guest to run in HVM container. This is done by adding pvh=1 in the
* config file.
*/
#define LIBXL_HAVE_PVH_SUPPORT 1
thanks
Mukesh
next prev parent reply other threads:[~2013-09-06 1:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 1:32 [V1 PATCH 0/5]: PVH xen tools: tools changes to create PVH guest Mukesh Rathor
2013-09-05 1:32 ` [V1 PATCH 1/5] PVH xen tools: Elf and header change Mukesh Rathor
2013-09-05 8:29 ` Jan Beulich
2013-09-05 1:32 ` [V1 PATCH 2/5] PVH xen tools: libxc changes to build a PVH guest Mukesh Rathor
2013-09-05 10:22 ` Ian Campbell
2013-09-06 1:12 ` Mukesh Rathor
2013-09-06 9:29 ` Ian Campbell
2013-09-06 21:04 ` Mukesh Rathor
2013-09-05 1:32 ` [V1 PATCH 3/5] PVH xen tools: libxl changes to create " Mukesh Rathor
2013-09-05 10:03 ` Ian Campbell
2013-09-06 1:23 ` Mukesh Rathor [this message]
2013-09-06 9:32 ` Ian Campbell
2013-09-05 1:32 ` [V1 PATCH 4/5] PVH xen tools: xenstored changes Mukesh Rathor
2013-09-05 10:04 ` Ian Campbell
2013-09-06 20:23 ` Mukesh Rathor
2013-09-05 1:32 ` [V1 PATCH 5/5] PVH xen tools: misc changes Mukesh Rathor
2013-09-05 10:06 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905182327.6cb14c15@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).