From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [V1 PATCH 2/5] PVH xen tools: libxc changes to
 build a PVH guest.
Date: Fri, 6 Sep 2013 14:04:53 -0700
Message-ID: <20130906140453.27b0bef5@mantra.us.oracle.com>
References: <1378344728-30624-1-git-send-email-mukesh.rathor@oracle.com>
	<1378344728-30624-3-git-send-email-mukesh.rathor@oracle.com>
	<1378376525.14745.22.camel@kazak.uk.xensource.com>
	<20130905181251.177d7cdd@mantra.us.oracle.com>
	<1378459742.14745.81.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <mukesh.rathor@oracle.com>) id 1VI3DD-0003w0-VH
	for xen-devel@lists.xenproject.org; Fri, 06 Sep 2013 21:05:06 +0000
In-Reply-To: <1378459742.14745.81.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian.Jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, 6 Sep 2013 10:29:02 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> On Thu, 2013-09-05 at 18:12 -0700, Mukesh Rathor wrote:
> > On Thu, 5 Sep 2013 11:22:05 +0100
> > Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > 
> > > On Wed, 2013-09-04 at 18:32 -0700, Mukesh Rathor wrote:
> > > > Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> > ...
> > > >      for ( i = 0; i < XENFEAT_NR_SUBMAPS; i++ )
> > > >      {
> > > > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> > > > index 126c0f8..5b2d61d 100644
> > > > --- a/tools/libxc/xc_dom_x86.c
> > > > +++ b/tools/libxc/xc_dom_x86.c
> > > 
> > > I don't seem to see anything which would reject PVH on x86_32 at
> > > the moment?
> > 
> > 32bit kernel wouldn't have the elf features so it would be rejected.
> 
> A RHEL5 i686 kernel-xen might actual implement all of these features,
> I think they did at one point?

Already discovered that, all except hvm callback vector.

> > Also, the hypervisor has checks for 32bit guest, and will fail one
> > of the hcalls used to build the guest.
> 
> Great. Will the error message be comprehensible? It would be a one
> line check and error message in vcpu_x86_32 if not.

Ok, added anyways.

thanks
mukesh