From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: [V2 PATCH 3/4] PVH xen tools: libxl changes to create a PVH guest. Date: Mon, 9 Sep 2013 18:40:47 -0700 Message-ID: <20130909184047.74250ae6@mantra.us.oracle.com> References: <1378513717-11525-1-git-send-email-mukesh.rathor@oracle.com> <1378513717-11525-4-git-send-email-mukesh.rathor@oracle.com> <1378716579.19967.10.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VJCws-0003iF-R4 for xen-devel@lists.xenproject.org; Tue, 10 Sep 2013 01:40:59 +0000 In-Reply-To: <1378716579.19967.10.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian.Jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 9 Sep 2013 09:49:39 +0100 Ian Campbell wrote: > On Fri, 2013-09-06 at 17:28 -0700, Mukesh Rathor wrote: > > V2: set c_info->hap to default value of pvh, and use LOG(ERROR...). > > Move PVH check to xc_dom_gnttab_init. > > Move xl doc change here. > > > > Signed-off-by: Mukesh Rathor > > --- > > docs/man/xl.cfg.pod.5 | 3 +++ > > tools/libxl/libxl.h | 6 ++++++ > > tools/libxl/libxl_create.c | 12 ++++++++++++ > > tools/libxl/libxl_dom.c | 2 ++ > > tools/libxl/libxl_internal.h | 1 + > > tools/libxl/libxl_types.idl | 1 + > > tools/libxl/libxl_x86.c | 4 +++- > > tools/libxl/xl_cmdimpl.c | 1 + > > 8 files changed, 29 insertions(+), 1 deletions(-) > > > > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 > > index 08d6cc4..4c925c9 100644 > > --- a/docs/man/xl.cfg.pod.5 > > +++ b/docs/man/xl.cfg.pod.5 > > @@ -634,6 +634,9 @@ if your particular guest kernel does not > > require this behaviour then it is safe to allow this to be enabled > > but you may wish to disable it anyway. > > > > +=item B > > +Selects whether to run this guest in an HVM container. Default is > > 0. > > ^ PV > > Will help stop people becoming confused and thinking this turns on HVM > mode. The change is under PV guest. HVM section os separate. But I can add it anyways. thanks Mukesh