From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Keir Fraser <keir.xen@gmail.com>,
Jan Beulich <JBeulich@suse.com>
Subject: [PATCH v2 0/6] some libxc cleanups and xen-mfndump
Date: Tue, 10 Sep 2013 19:53:32 +0200 [thread overview]
Message-ID: <20130910174758.7735.13358.stgit@hit-nxdomain.opendns.com> (raw)
Hi everyone,
This is take 2 of an old submission of mine, doing some basic libxc cleanups
and introducing a debugging tool I called xen-mfndump.
Basically, there are a few places in libxc where we issue do_domctl()-s
directly, instead of using the proper xc_xxx() wrapper. This make the code
bigger, redundant, more difficult to understand (e.g., "why xc_xxx() is called
here and is not called there?"), less consistent and less grep-able. The first
4 patches of this series address this.
The last one introduce a little tool I'm using for debugging. It allows one to
see the M2P of the host, the P2M of a domain, some info about the PTEs, and
perform basic searches and comparisons on them. I'm finding it very useful and,
although I do not claim for my situation to be that common, I figured it could
be nice to have it in the tree, so that is patch 6. Patch 5 is the small
rework/additions necessary to make 6 possible.
Patches with an '*' next to their name below have been Reviewed-by Andrew
Cooper.
Thanks and Regards,
Dario
---
Dario Faggioli (6):
libxc: introduce xc_domain_get_guest_width()
* libxc: use xc_vcpu_setcontext() instead of calling do_domctl()
libxc: use xc_vcpu_getinfo() instead of calling do_domctl()
* libxc: allow for ctxt to be NULL in xc_vcpu_setcontext
libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo)
tools/misc: introduce xen-mfndump.
tools/libxc/xc_core.c | 20 --
tools/libxc/xc_cpuid_x86.c | 8 -
tools/libxc/xc_dom_boot.c | 31 +--
tools/libxc/xc_dom_x86.c | 13 -
tools/libxc/xc_domain.c | 149 +++++++++++++-
tools/libxc/xc_domain_restore.c | 13 -
tools/libxc/xc_offline_page.c | 192 +++---------------
tools/libxc/xc_pagetab.c | 8 -
tools/libxc/xc_private.c | 8 -
tools/libxc/xc_resume.c | 21 --
tools/libxc/xenctrl.h | 13 +
tools/libxc/xenguest.h | 17 ++
tools/libxc/xg_private.h | 9 +
tools/libxc/xg_save_restore.h | 9 -
tools/misc/Makefile | 7 -
tools/misc/xen-mfndump.c | 425 +++++++++++++++++++++++++++++++++++++++
tools/xentrace/xenctx.c | 9 -
17 files changed, 679 insertions(+), 273 deletions(-)
create mode 100644 tools/misc/xen-mfndump.c
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
next reply other threads:[~2013-09-10 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 17:53 Dario Faggioli [this message]
2013-09-10 17:53 ` [PATCH v2 1/6] libxc: introduce xc_domain_get_guest_width() Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 2/6] libxc: use xc_vcpu_setcontext() instead of calling do_domctl() Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 3/6] libxc: use xc_vcpu_getinfo() " Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 4/6] libxc: allow for ctxt to be NULL in xc_vcpu_setcontext Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 5/6] libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo) Dario Faggioli
2013-09-13 12:05 ` Ian Campbell
2013-09-13 12:21 ` Dario Faggioli
2013-09-13 12:24 ` Ian Campbell
2013-09-13 13:02 ` Dario Faggioli
2013-09-13 13:12 ` Ian Campbell
2013-09-13 13:25 ` Ian Campbell
2013-09-13 13:35 ` Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 6/6] tools/misc: introduce xen-mfndump Dario Faggioli
2013-09-11 8:09 ` [PATCH v2 0/6] some libxc cleanups and xen-mfndump Dario Faggioli
2013-09-13 12:33 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910174758.7735.13358.stgit@hit-nxdomain.opendns.com \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).