xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>, Keir Fraser <keir.xen@gmail.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: [PATCH v2 4/6] libxc: allow for ctxt to be NULL in xc_vcpu_setcontext
Date: Tue, 10 Sep 2013 19:54:05 +0200	[thread overview]
Message-ID: <20130910175404.7735.78281.stgit@hit-nxdomain.opendns.com> (raw)
In-Reply-To: <20130910174758.7735.13358.stgit@hit-nxdomain.opendns.com>

Since, as can be seen in xen/common/domctl.c, that is legitimate
(it results in Xen calling vcpu_reset() on the vcpu).

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
Changes from v1:
 * clarified the changelog.
---
 tools/libxc/xc_domain.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index c0ce079..3210e34 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1141,12 +1141,6 @@ int xc_vcpu_setcontext(xc_interface *xch,
     DECLARE_HYPERCALL_BOUNCE(ctxt, sizeof(vcpu_guest_context_any_t), XC_HYPERCALL_BUFFER_BOUNCE_IN);
     int rc;
 
-    if (ctxt == NULL)
-    {
-        errno = EINVAL;
-        return -1;
-    }
-
     if ( xc_hypercall_bounce_pre(xch, ctxt) )
         return -1;

  parent reply	other threads:[~2013-09-10 17:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 17:53 [PATCH v2 0/6] some libxc cleanups and xen-mfndump Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 1/6] libxc: introduce xc_domain_get_guest_width() Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 2/6] libxc: use xc_vcpu_setcontext() instead of calling do_domctl() Dario Faggioli
2013-09-10 17:53 ` [PATCH v2 3/6] libxc: use xc_vcpu_getinfo() " Dario Faggioli
2013-09-10 17:54 ` Dario Faggioli [this message]
2013-09-10 17:54 ` [PATCH v2 5/6] libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo) Dario Faggioli
2013-09-13 12:05   ` Ian Campbell
2013-09-13 12:21     ` Dario Faggioli
2013-09-13 12:24       ` Ian Campbell
2013-09-13 13:02         ` Dario Faggioli
2013-09-13 13:12           ` Ian Campbell
2013-09-13 13:25             ` Ian Campbell
2013-09-13 13:35               ` Dario Faggioli
2013-09-10 17:54 ` [PATCH v2 6/6] tools/misc: introduce xen-mfndump Dario Faggioli
2013-09-11  8:09 ` [PATCH v2 0/6] some libxc cleanups and xen-mfndump Dario Faggioli
2013-09-13 12:33 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130910175404.7735.78281.stgit@hit-nxdomain.opendns.com \
    --to=dario.faggioli@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=keir.xen@gmail.com \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).