From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xen.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@citrix.com>,
Juergen Gross <juergen.gross@ts.fujitsu.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided
Date: Wed, 11 Sep 2013 13:06:22 +0200 [thread overview]
Message-ID: <20130911110612.14048.93476.stgit@hit-nxdomain.opendns.com> (raw)
since it errors out, asking for at least one argument, and does
not display any useful output, which is wrong (we want the list
and the info about all the existing cpupools).
IOW, the output is as follows:
~# xl cpupool-list -c
'xl cpupool-list' requires at least 1 argument.
...
While it should be as follows:
~# xl cpupool-list -c
Name CPU list
Pool-0 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
tools/libxl/xl_cmdimpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 884f050..35b3e29 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -6570,7 +6570,7 @@ int main_cpupoollist(int argc, char **argv)
char *name;
int ret = 0;
- SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 1) {
+ SWITCH_FOREACH_OPT(opt, "hc", opts, "cpupool-list", 0) {
case 'c':
opt_cpus = 1;
break;
next reply other threads:[~2013-09-11 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 11:06 Dario Faggioli [this message]
2013-09-11 11:13 ` [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided Juergen Gross
2013-09-13 9:51 ` Dario Faggioli
2013-09-13 12:35 ` Ian Campbell
2013-09-13 13:27 ` Backport request for 4.3.x [was: Re: [PATCH] xl: fix `xl cpupool-list' behavior in case no pool name is provided] Dario Faggioli
2013-09-13 13:48 ` Ian Jackson
2013-09-13 14:01 ` Dario Faggioli
2013-10-11 17:55 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911110612.14048.93476.stgit@hit-nxdomain.opendns.com \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).