From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] qemu-traditional: do not strip binaries
 during make install
Date: Thu, 19 Sep 2013 09:41:48 +0200
Message-ID: <20130919074148.GA19829@aepfle.de>
References: <1379527888-5651-1-git-send-email-olaf@aepfle.de>
	<CA+nUz_KVgDbAk_mgsjAh94ABSajHy3FFsRR1juWeCXjRn-V6Ew@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <CA+nUz_KVgDbAk_mgsjAh94ABSajHy3FFsRR1juWeCXjRn-V6Ew@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, Sep 19, Matthew Daley wrote:

> On Thu, Sep 19, 2013 at 6:11 AM, Olaf Hering <olaf@aepfle.de> wrote:
> > @@ -243,7 +243,7 @@ endif
> >  install: all $(if $(BUILD_DOCS),install-doc)
> >         mkdir -p "$(DESTDIR)$(bindir)"
> >  ifneq ($(TOOLS),)
> > -       $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> > +       $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
> >  endif
> >  ifneq ($(BLOBS),)
> >         mkdir -p "$(DESTDIR)$(datadir)"
> > diff --git a/Makefile.target b/Makefile.target
> > index 19bb0fd..1cf7f34 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -755,7 +755,7 @@ clean:
> >
> >  install: all install-hook
> >  ifneq ($(PROGS),)
> > -       $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
> > +       $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> 
> Perhaps it would be worthwhile to only do this if debug=y is set, like
> in commit 8e4610e (which is the equivalent of this patch for
> qemu-xen)?

I dont think any "make install" has to modify the binaries. If debuginfo
was requested by passing "-g" via CFLAGS then the generated debuginfo
has to be preserved during make install.

Olaf