* [PATCH] xen/x86: add a comment regarding how to get the VCPU ID on HVM
@ 2013-09-23 16:55 Roger Pau Monne
2013-09-23 17:10 ` Matt Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2013-09-23 16:55 UTC (permalink / raw)
To: xen-devel; +Cc: Keir Fraser, Matt Wilson, Jan Beulich, Roger Pau Monne
Add a note to the public headers regarding how to get the VCPU ID for
HVM guests (on x86).
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Matt Wilson <msw@amazon.com>
---
This is what Linux PVHVM does AFAIK, and also what I've been using in
my FreeBSD PVHVM series, but it's not written anywere.
---
xen/include/public/vcpu.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h
index e888daf..a5ca44d 100644
--- a/xen/include/public/vcpu.h
+++ b/xen/include/public/vcpu.h
@@ -35,6 +35,9 @@
* @cmd == VCPUOP_??? (VCPU operation).
* @vcpuid == VCPU to operate on.
* @extra_args == Operation-specific extra arguments (NULL if none).
+ *
+ * For x86 HVM domains that use VCPU operations the VCPU ID is the ACPI ID
+ * of the CPU, as fetched from the MADT table.
*/
/*
--
1.7.7.5 (Apple Git-26)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/x86: add a comment regarding how to get the VCPU ID on HVM
2013-09-23 16:55 [PATCH] xen/x86: add a comment regarding how to get the VCPU ID on HVM Roger Pau Monne
@ 2013-09-23 17:10 ` Matt Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Matt Wilson @ 2013-09-23 17:10 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: xen-devel, Keir Fraser, Jan Beulich, Matt Wilson
On Mon, Sep 23, 2013 at 06:55:29PM +0200, Roger Pau Monne wrote:
> Add a note to the public headers regarding how to get the VCPU ID for
> HVM guests (on x86).
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Matt Wilson <msw@amazon.com>
> ---
> This is what Linux PVHVM does AFAIK, and also what I've been using in
> my FreeBSD PVHVM series, but it's not written anywere.
What about rewording slightly to:
For x86 HVM domains that use VCPU operations the VCPU ID is the ACPI
Processor ID of the CPU (not to be confused with the APIC ID), as
fetched from the MADT table.
The field is "ACPI Processor ID" in the spec.
Otherwise:
Acked-by: Matt Wilson <msw@amazon.com>
--msw
> ---
> xen/include/public/vcpu.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/xen/include/public/vcpu.h b/xen/include/public/vcpu.h
> index e888daf..a5ca44d 100644
> --- a/xen/include/public/vcpu.h
> +++ b/xen/include/public/vcpu.h
> @@ -35,6 +35,9 @@
> * @cmd == VCPUOP_??? (VCPU operation).
> * @vcpuid == VCPU to operate on.
> * @extra_args == Operation-specific extra arguments (NULL if none).
> + *
> + * For x86 HVM domains that use VCPU operations the VCPU ID is the ACPI ID
> + * of the CPU, as fetched from the MADT table.
> */
>
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-23 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 16:55 [PATCH] xen/x86: add a comment regarding how to get the VCPU ID on HVM Roger Pau Monne
2013-09-23 17:10 ` Matt Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).