From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 12/13] xen/events: Add the hypervisor interface for the FIFO-based event channels Date: Tue, 24 Sep 2013 12:51:27 -0400 Message-ID: <20130924165126.GC14032@phenom.dumpdata.com> References: <1379091601-30358-1-git-send-email-david.vrabel@citrix.com> <1379091601-30358-13-git-send-email-david.vrabel@citrix.com> <20130924150856.GL4712@phenom.dumpdata.com> <5241B9CA.9030005@cantab.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5241B9CA.9030005@cantab.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel Cc: Boris Ostrovsky , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Sep 24, 2013 at 05:11:54PM +0100, David Vrabel wrote: > On 24/09/2013 16:08, Konrad Rzeszutek Wilk wrote: > >> +/* > >> + * FIFO ABI > >> + */ > >> + > >> +/* Events may have priorities from 0 (highest) to 15 (lowest). */ > >> +#define EVTCHN_FIFO_PRIORITY_MIN 15 > >> +#define EVTCHN_FIFO_PRIORITY_DEFAULT 7 > >> + > >> +#define EVTCHN_FIFO_MAX_QUEUES (EVTCHN_FIFO_PRIORITY_MIN + 1) > >> + > >> +typedef uint32_t event_word_t; > > > > Typedefs are frowed upon in the Linux kernel. Can you just use uint32_t > > please? > > Checkpatch frowned at this too but I just frowned back. I think this > specific typedef improves maintainability so I'm not inclined to remove > it to satisfy an arbitrary rule. typedefs it is then. > > David