From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: jun.nakajima@intel.com, George.Dunlap@eu.citrix.com,
jacob.shin@amd.com, eddie.dong@intel.com,
dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org,
JBeulich@suse.com, suravee.suthikulpanit@amd.com
Subject: Re: [PATCH v2 01/13] Export hypervisor symbols
Date: Tue, 24 Sep 2013 13:40:35 -0400 [thread overview]
Message-ID: <20130924174035.GF14176@phenom.dumpdata.com> (raw)
In-Reply-To: <52409F56.9090208@oracle.com>
On Mon, Sep 23, 2013 at 04:06:46PM -0400, Boris Ostrovsky wrote:
> On 09/23/2013 03:42 PM, Konrad Rzeszutek Wilk wrote:
> >On Fri, Sep 20, 2013 at 05:42:00AM -0400, Boris Ostrovsky wrote:
> >
> >I think the title needs a prefix of say: "xen/platform_op:" or such.
> >
> >>Export Xen's symbols in format similar to Linux' /proc/kallsyms.
> >Which is?
> >
> >I see in Linux:
> >
> >000000000000bd58 D xen_cr3
> >...
> >000000000000e978 d soft_lockup_hrtimer_cnt
> >..
> >ffffffff8101cef0 T eager_fpu_init
> >ffffffff8101d010 t ptrace_triggered
> >
> >I know that the first column is the EIP (thought some of them seem to be
> >based on some offset). The last one is pretty obvious too.
> >
> >But the middle one:
> >konrad@phenom:~$ cat /proc/kallsyms | awk '{print $2}' | sort | uniq
> >b
> >B
> >d
> >D
> >r
> >R
> >t
> >T
> >V
> >W
> >
> >Could you explain what those mean? And are they part of this?
> >Or does Xen not carry those?
>
> These are symbol types, described in 'man nm'. For Xen we should
<sigh> I was doing 'man kallsyms' which of course would not give me that.
> only see 't' and 'T' which denote local or global text symbol.
>
> So the format would be
> <address> <type> <symbol name>
>
> In any case, this is not a comlpetely correct commit message, it
> really describes to v1 implementation. With v2 Xen will return these
> three values in a structure, which has nothing to do with *format*
> of how these symbols are presented. I'll re-phrase it.
Thank you. Sorry for the noise - it didn't occur for me to check 'nm' :-(
>
> (And there other remnants of v1 in this patch that I just noticed,
> such as changes to xen/tools/symbols.c which are no longer needed)
next prev parent reply other threads:[~2013-09-24 17:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 9:41 [PATCH v2 00/13] x86/PMU: Xen PMU PV support Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 01/13] Export hypervisor symbols Boris Ostrovsky
2013-09-23 19:42 ` Konrad Rzeszutek Wilk
2013-09-23 20:06 ` Boris Ostrovsky
2013-09-24 17:40 ` Konrad Rzeszutek Wilk [this message]
2013-09-25 13:15 ` Jan Beulich
2013-09-25 14:03 ` Boris Ostrovsky
2013-09-25 14:53 ` Jan Beulich
2013-09-20 9:42 ` [PATCH v2 02/13] Set VCPU's is_running flag closer to when the VCPU is dispatched Boris Ostrovsky
2013-09-25 13:42 ` Jan Beulich
2013-09-25 14:08 ` Keir Fraser
2013-09-20 9:42 ` [PATCH v2 03/13] x86/PMU: Stop AMD counters when called from vpmu_save_force() Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 04/13] x86/VPMU: Minor VPMU cleanup Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 05/13] intel/VPMU: Clean up Intel VPMU code Boris Ostrovsky
2013-09-23 11:42 ` Dietmar Hahn
2013-09-23 19:46 ` Konrad Rzeszutek Wilk
2013-09-25 13:55 ` Jan Beulich
2013-09-25 14:39 ` Boris Ostrovsky
2013-09-25 14:57 ` Jan Beulich
2013-09-25 15:37 ` Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 06/13] x86/PMU: Add public xenpmu.h Boris Ostrovsky
2013-09-23 13:04 ` Dietmar Hahn
2013-09-23 13:16 ` Jan Beulich
2013-09-23 14:00 ` Boris Ostrovsky
2013-09-23 13:45 ` Boris Ostrovsky
2013-09-25 14:04 ` Jan Beulich
2013-09-25 15:59 ` Boris Ostrovsky
2013-09-25 16:08 ` Jan Beulich
2013-09-30 13:25 ` Boris Ostrovsky
2013-09-30 13:30 ` Jan Beulich
2013-09-30 13:55 ` Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 07/13] x86/PMU: Make vpmu not HVM-specific Boris Ostrovsky
2013-09-25 14:05 ` Jan Beulich
2013-09-25 14:49 ` Boris Ostrovsky
2013-09-25 14:57 ` Jan Beulich
2013-09-20 9:42 ` [PATCH v2 08/13] x86/PMU: Interface for setting PMU mode and flags Boris Ostrovsky
2013-09-25 14:11 ` Jan Beulich
2013-09-25 14:55 ` Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 09/13] x86/PMU: Initialize PMU for PV guests Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 10/13] x86/PMU: Add support for PMU registes handling on " Boris Ostrovsky
2013-09-23 13:50 ` Dietmar Hahn
2013-09-25 14:23 ` Jan Beulich
2013-09-25 15:03 ` Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 11/13] x86/PMU: Handle PMU interrupts for " Boris Ostrovsky
2013-09-25 14:33 ` Jan Beulich
2013-09-25 14:40 ` Andrew Cooper
2013-09-25 15:52 ` Boris Ostrovsky
2013-09-25 15:19 ` Boris Ostrovsky
2013-09-25 15:25 ` Jan Beulich
2013-09-20 9:42 ` [PATCH v2 12/13] x86/PMU: Save VPMU state for PV guests during context switch Boris Ostrovsky
2013-09-20 9:42 ` [PATCH v2 13/13] x86/PMU: Move vpmu files up from hvm directory Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924174035.GF14176@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=eddie.dong@intel.com \
--cc=jacob.shin@amd.com \
--cc=jun.nakajima@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).